Duplicate faker groups (Money and Currency) about datafaker HOT 9 CLOSED

Good point. Might make sense to deprecate Currency, delegate everything to Money, and we will remove Currency in 2.4 or 3.0. Would that work?

from datafaker.

Yes, I think this will work.

+1 to remove deprecated Currency faker group in the 3.0 version

from datafaker.

I wonder why we have this class at all?
there is a java class java.util.Currency which could be reused instead of duplicating logic with yaml file which is slower

so I would remove one and for the second remove yaml and replace logic with calls to java.util.Currency

from datafaker.

@snuyanzin good question. I think faker.Currency is pre Java 8, while util.Currency was introduced in Java 8. Might make sense to migrate it.

from datafaker.

In fact it is present in Java since 1.4 ...
In javadocs it is stated that it done based on ISO 4217, so probably would be better to use it

from datafaker.

@bodiam , @panilya am I right that this one now can be closed?

from datafaker.

I think so.

Maybe it also makes sense to leave somewhere a reminder to delete Currency faker in the 3.0.0 release

from datafaker.

I think it will be deleted in version 2.4.0 or 2.5.0. I know it's not entirely "semver", but 3.0 to me sounds like a huge milestone, not just the removal of a class which is is probably used by only a small set of our users.

from datafaker.

The code/javadoc have the removal todo details.

from datafaker.