datawire / dlib Goto Github PK

All globals must go.

The 1.x dlog.Logger interface is simple-to-implement but "slow" in that non-logged formatting can't be optimized out. Implementations can opt-in to such an optimization by also implementing the dlog.OptmizedLogger interface, but it's more complex.

There's some thinking that it's a design flaw that it's so easy to do the slow thing.

See the discussion on #33

dgroup's shutdown logging works by watching the Context and logging when it observes that it becomes Done. Because this is async, the ordering of the shutdown log line might actually come after things caused by the shutdown. This is confusing and makes the logs hard to read.

This should be solvable by wrapping the Context in our own Context implementation that logs before propagating the cancelation to child Contexts.

It would be good to avoid forcing users to pull in transient dependencies of things they don't need.

The logging of dexec.Cmd() can be turned on or off using the DisableLogging flag, but there is no way to control how much output the command generates and it's generally very verbose. In many situations, all the reader of a log wants to know is if the command executed and if something went wrong.

I would like a way to control this so that only the command string is logged and, unless there's an error (output to stderr or non-zero exit code) nothing else.