dataxu / dxskytap Goto Github PK

Makefile contains paths which include "/". These will not work on Windows. I am not sure how this should be handled.

The docstring for RestBase.init() does not include all the method's parameters nor are all the descriptions complete.

Remove the import of dxskytap.restobject.RestObject, as it is not used.

Some methods which are not trivial do not have docstrings. Some methods which have docstrings do not contain parameter descriptions, do not contain return value descriptions, or format them inconsistently

Consider the Google docstring style: http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Comments

It would be nice if ".skytap_config" was not hardcoded but rather defined as a constant at the top of the file. It is located in init.py

Add feature to library to upload (import) VM from a local file.
Add feature to library to download (export) VM to a local file.

In README.md, "dxautoskytap" is referenced instead of "dxskytap"

The latter form is not valid Python 3 syntax.

There are 3 instances in restobject.py

In Tunnels.create_tunnel(), Tunnel() is called with 4 arguments. Tunnel() only supports 3 arguments.

There is a TODO in Configuration.wait_for().

In Connect._log_header_body(), the self.logger.debug() calls should pass the string parameters in as arguments to debug(). In the current implementation, the replacement occurs regardless of the logging level. If it were changed, the replacement would only occur when the message is logged.

New style classes should call the parent constructor like this:
super(ChildClass, self).init()
rather than:
ParentClass.init()

A new style class is basically any class that inherits.

There are 2 instances of multiple statements per line:
In Configuration.check_state() and VirtualMachine.check_state()

Please put each statement on a separate line for readability

Should this file be included in the repo? Is there anything DX specific in it?

To create a disk on a VM, use a PUT command to modify your particular VM resource using the following syntax:
{"hardware":
{"disks":
{"new": [8092] }
}
}
To delete a disk on a VM, use a PUT command to modify your particular VM resource. Use the syntax below, specifying the disk to be deleted by the unique disk ID:
{"hardware":
{"disks":
{"existing":
{"disk-924270-2248764-scsi-0-1":
{"id": "disk-924270-2248764-scsi-0-1", "size": null}
}
}
}
}
Use this information to add the ability to create/delete additional disks to the dxskytap library.

In the Skytap constructor, the following code exists:
filepath = os.getenv('HOME') + "/.skytap_config"

I believe this should be:
os.path.join(os.getenv('HOME'), ".skytap_config")

The current code will not work on Windows.