davbfr / flutter_about Goto Github PK

Any plans to support null safety?

Hello, it would be nice if you can add styling to the markdownpages, like padding, textscaling, etc. Is this already possible in the current version, or is this a new feature to be added?

Thanks for the great plugin!

It seems to need Pubspec, for things like version, but here that wont import..
This leads to failled assertion line 190, field version not found

Is your feature request related to a problem? Please describe.
When using the library's LicenseListPage (or showLicensePage), the ScaffoldBuilder originally passed to the LicenseListPage is not used for the LicenseDetail. There seems to be no way to define the ScaffoldBuilder for the LicenseDetail, short of rewriting the LicenseListPage yourself.

(I'm using the bitsdojo_window package to get a combined app/title bar on Linux and macOS, which makes it imperative that every single Scaffold uses a custom AppBar that allows moving the window and makes room for the window controls. That's why overriding the ScaffoldBuilder is extremely important to me.)

Describe the solution you'd like
LicenseDetail should use the same ScaffoldBuilder as the one passed to the LicenseListPage.

Describe alternatives you've considered
Alternatively, LicenseListPage could have a property like detailScaffoldBuilder, which would allow defining a separate ScaffoldBuilder for the LicenseDetail page.

Describe the bug
when running on desktop if the markdown has a link, like "Buy My COffee" in the example, it fails to show the image

The markup it fails on is:

The link to the Website https://www.buymeacoffee.com/JORBmbw9h does work

To Reproduce

Just run the example

error is:

Another exception was thrown: SocketException: Connection failed (OS Error: Operation not
permitted, errno = 1), address = bmc-cdn.nyc3.digitaloceanspaces.com, port = 443
flutter: Try ./README-en_US.md
flutter: Try ./README-en.md
flutter: Try README.md
flutter: Loaded README.md

Another exception was thrown: SocketException: Connection failed (OS Error: Operation not
permitted, errno = 1), address = bmc-cdn.nyc3.digitaloceanspaces.com, port = 443

Expected behavior

Show the image.

Screenshots

Flutter Doctor

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, 2.1.0-12.2.pre, on macOS 11.2.3 20D91 darwin-x64, locale en-DE)
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for
      detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[!] Android Studio (not installed)
[✓] VS Code (version 1.55.0)
[✓] Connected device (2 available)

! Doctor found issues in 2 categories.




**Desktop (please complete the following information):**
 - [ ] iOS
 - [ ] Android
 - [ ] Browser
 - [x ] MAC 

**Smartphone (please complete the following information):**
 - Device: [e.g. iPhone6]
 - OS: [e.g. iOS8.1]
 - Browser [e.g. stock browser, safari]
 - Version [e.g. 22]

**Additional context**
Add any other context about the problem here.

Can someone tell me how to use UrlMarkdownTapHandler
thanks

This code is designed to only load a defined set on markdown and other files, but i was wondering if it could also load a folder called "doc", and then display the markdown in those docs.

Would need to add a tree folder widget too i guess to allow the docs to be nested.

The reason is because i want to include user docs with this package also, and no just dev docs.

I know this package is NOT what this is designed explicitly for, but figured its worth asking about it.

Its very cool but it reflects on the pub spec at build time, etc

What command or configuration are you using to generate the pubspec.dart file in the example folder? Are you using https://pub.dev/packages/pubspec_generator for that?

Is your feature request related to a problem? Please describe.
When using this I love the MarkdownPageListTile option, which makes things much easier. But I miss similar option for hyperlinks. I know I probably can create my own ListTile combined with url_launcher, but it would be awesome to have it also in the library.

Describe the solution you'd like
ExternalLinkListTile would just be awesome.

Describe alternatives you've considered
I already managed to create my own, but it has some issues as I'm unable to copy MarkdownPageListTile from your library properly for myself.

Modified licenses.dart as follows:

          exerpt = license.paragraphs.first.text.split('.').first.trim();
          if (exerpt.length > 70) {
            exerpt = exerpt.substring(0, 70) + '...';
          }
          if (exerpt.startsWith('//') || exerpt.startsWith('/*')) {
            exerpt = exerpt.substring(2).trim();
          }

Is your feature request related to a problem? Please describe.
My app has got specific "go back" icons in all places. These are the only ones I was unable to change to the same style. Would it be possible to add an option to change also this icon?

Describe the solution you'd like
MarkdownPageListTile(returnIcon: Icons.navigate_before) could be the option.

Describe alternatives you've considered
I considered to avoid your package at all, but I was unable to recreate your amazing MarkdownPageListTile and MarkdownPage at all!

Describe the bug
When I run on Linux (UBUNTU) 22.00 I face this issue:

ERROR: ../../.pub-cache/hosted/pub.dev/about-2.1.1/lib/src/utils.dart:45:5: Error: No named parameter with the name 'accentColor'.
ERROR:     accentColor: theme.primaryContrastingColor,
ERROR:     ^^^^^^^^^^^
ERROR: ../../snap/flutter/common/flutter/packages/flutter/lib/src/material/theme_data.dart:288:11: Context: Found this candidate, but the arguments don't match.
ERROR:   factory ThemeData({
ERROR:           ^
ERROR: Target kernel_snapshot failed: Exception

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Flutter Doctor
Paste the output of running flutter doctor -v here.

[\u2713] Flutter (Channel master, 3.9.0-1.0.pre.55, on Ubuntu 22.04.2 LTS 5.15.0-67-generic,
    locale en_US.UTF-8)
    \u2022 Flutter version 3.9.0-1.0.pre.55 on channel master at
      /home/francesco/snap/flutter/common/flutter
    \u2022 Upstream repository https://github.com/flutter/flutter.git
    \u2022 Framework revision d696b05165 (7 minutes ago), 2023-03-06 11:41:59 +0000
    \u2022 Engine revision 197b6dae1c
    \u2022 Dart version 3.0.0 (build 3.0.0-290.0.dev)
    \u2022 DevTools version 2.22.2

[\u2717] Android toolchain - develop for Android devices
    \u2717 Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for
      detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.


[\u2717] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[\u2713] Linux toolchain - develop for Linux desktop
    \u2022 clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    \u2022 cmake version 3.10.2
    \u2022 ninja version 1.8.2
    \u2022 pkg-config version 0.29.1

[!] Android Studio (not installed)
    \u2022 Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/linux#android-setup for detailed
      instructions).

[\u2713] VS Code (version 1.76.0)
    \u2022 VS Code at /usr/share/code
    \u2022 Flutter extension can be installed from:
      \U0001f528 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[\u2713] Connected device (1 available)
    \u2022 Linux (desktop) \u2022 linux \u2022 linux-arm64 \u2022 Ubuntu 22.04.2 LTS 5.15.0-67-generic

[\u2713] Network resources
    \u2022 All expected network resources are available.

_fe_analyzer_shared (Unhandled Exception: RangeError (index): Invalid value: Valid value range is empty: 0)
flutter_inappwebview (The expected name is 'Flutter InAppWebView', but it is 'Flutter Inappwebview')
json_rpc_2(The expected name is 'JSON-RPC 2.0', but it is 'Json Rpc 2')

Bad code as follows:

      String packageName = '';
      for (String word in package.split('_')) {
        packageName += word[0].toUpperCase() + word.substring(1) + ' ';
      }

Why not use the original package name ?

      String packageName = package;
      //for (String word in package.split('_')) {
      //  packageName += word[0].toUpperCase() + word.substring(1) + ' ';
      //}

Is your feature request related to a problem? Please describe.
My app doesn't have top appBar, it always uses navbar to navigate and open menus etc. I would like to disable appBar from about page as it's the only widget with appBar.