daveadams / go-rapture Goto Github PK

I just tried to assume a role with an alias that wasn't defined and got an error message that was confusing at first.

ERROR: Could not assume role 'inst-por': InvalidParameter: 1 validation error(s) found.
- minimum field size of 20, AssumeRoleInput.RoleArn.

It would be nice to catch that this was an alias that wasn't defined and give an error indicating the problem. I may have some time to take a pass at fixing this tomorrow or Saturday.

Has support for the credential_process option in a ~/.aws/config profile been considered?

It would be convenient for support with applications like vscode.

This may be more of a vaulted responsibility so please direct my attention if it is looking for a solution in the wrong place.

Hey dadams hope you're doing well,

Although Vaulted "techincally" supports shells with / in their name it seems rapture does not:

$ vaulted -n tetrate/hub
Vault 'tetrate/hub'
   Password: 
   MFA token: <snipped>
tetrate/hub — expires: 7 Oct 2020 04:56 UTC (35h59m58s remaining)
$ rapture init tetrate/hub
ERROR: No such vault 'tetrate/hub'

I'm guessing this is mostly a side effect of it not appearing in vaulted ls, but it'd be nice to have parity here. I understand though if fixing the bug in vaulted is the right answer, just figured I'd let you know about this discrepancy regardless.

When the calling shell is different from the one specified in $SHELL then shell-init will generate wrong shell code which can not be eval'd.

The current case is: fish is specified as a Terminal start command and the user login shell is not modified, so $SHELL is /bin/bash but fish shell code is expected.

A possible solution would be to add flags to shell-init (-f, -s, -z) to force a specific shell type.