Giter VIP home page Giter VIP logo

bmac's Introduction

Hello there ๐Ÿ‘€

Dave's GitHub stats

bmac's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

bmac's Issues

Request: Delete all bookings from a event

There are some cases where bookings are imported, however, due to an mistake in the import file, some / all bookings have wrong values.

For a while, removing all bookings was done by either re-creating the event, manually removing bookings 1 by 1, or running a query DELETE FROM bookings WHERE event_id = ?. Foreign keys are already in place to make sure data between bookings and flights are deleted as needed.

It would save time if there is a button called Delete all bookings that removes all bookings. Because import is usually done after creating event, I'm not planning on adding a extra check if a flight is already booked or not.

Airport: Add LAT LON data

For #193 I need LAT LON data to show airports. Right now, they're not saved at all. The import file that's already in use does have such data.

BookingImport: Auto-add missing airport

Instead of using the airport import script (that loads in airports we don't need), it would be nice to have them auto-added to the database if it's missing while running a booking import.

Low priority, #432 adds the ability to also search through airports

Slot edit issue

Hello!
I've got issue with Book button.
If someone booked the slot already - I still have "book now" button.
image
And if you click on it - it tells that the slot is booked by someone.

The next issue is that if I book the slot - I can't drop it.
image
It tells me "you already have a booking". Only way what I can do - fully remove the slot to release it. (via admin)

API: Add some booking numbers

Request: Add the following fields to app/Http/Resources/EventResource.php:

  • url: URL of the event. Example: 'https://bmac.daveroverts.nl/random-test-event/bookings'.
  • total_bookings_count: [int] Total bookings that are in the system for the event. Example: 30.
  • available_bookings_count: [int] Bookings that are still available to be booked. Example: 28.

The data we need is already shown in the bookings table.

$this->booked = $this->bookings->where('status', BookingStatus::BOOKED)
->filter(function ($booking) {
/** @var Booking $booking */
return $booking->flights_count;
})->count();
if ($this->event->event_type_id == EventType::MULTIFLIGHTS) {
$this->total = $this->bookings->count();
} else {
$this->total = $this->bookings->sum(function ($booking) {
/** @var Booking $booking */
return $booking->flights_count;
});
}

Note 2 self: #375 has edited that file a bit. Maybe merge that in first before beginning with this issue.

Final Information E-mail: Make it editable (within limits)

A nice follow-up on #119 would be to make the e-mail editable (within limits).

Initially, I'm thinking of this order:

  • Salutation
  • Content
  • Booking details

What also would be possible is to use something like [booking_details] within tinymce to show all details there instead

Syntax Error on bookings table

It seems that there is a syntax error when on the bookings table (i.e. /bookings). Get this error: syntax error, unexpected 'Event' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) (View: /var/www/booking/resources/views/booking/overview.blade.php)

Using dev branch (latest). Master branch has no difference.

Add option to delete unused airports

The import script is fun and all, but maybe it's a good idea to implement a script that can delete airports that haven't been used.

The following conditions should be applied:

  • Not coupled to a Event
  • Not coupled to a Booking
  • Not coupled to a AirportLink

Usage of Accessors and raw values

Right now, the usage of accessors and raw values are mixed, this needs to be corrected in the whole application.

  • Accessors: Should be used within views to output something
  • Raw values: Must be used in forms

Forms: Times sometimes show as 12h

Times currently use the default <input type="time">, good if your browser language is something like Dutch, but not if it's in something like English, where the 12h format is shown

TinyMCE not displaying

Hi,

I have set up the project as described and it works well except for the fact that the description field on the events page does not show up. It seems to be because it has visibility is hidden and the TinyMCE is not activating correctly. I have attached screenshots of a couple of things I noticed that seem to be related. I'm not all that familiar with Laravel otherwise I would have fixed it myself.

Screenshots:
Add/edit event page
a

DOM of descripion field
b

Last tag in head
c

Any assistance would ve appreciated. Thanks

When env doesn't send out e-mails, don't notify that a e-mail was sent

I know one environment that doesn't send out E-mails out at all. However, some flash messages clearly show a e-mail was sent.

The following lines show this:

'Booking has been created! An E-mail with details has also been sent');
$message = 'Booking has been removed! A E-mail has also been sent';

Now the question is: Do I want to remove that bit of message al together, or only show it if env actually sends out e-mails?

Implement Laravel Echo for bookings.overview

Now that I've added Laravel Livewire to bookings.overview, it would be nice to also add Laravel Echo for that page, so that you can see each booking change depending on what's happening.

In my opinion, this whole feature should be optional. Events will always broadcast, but if you don't setup broadcasting, nothing happens on the client side.

Upgrade to Bootstrap 5

Related with #406. Bootstrap 5 dropped jQuery as required dependency.

Note to self: Do this after #432 to reduce potential unneeded work

First Artisan Migrate

Hello, i make the first Artisan Migrate from last release

image

this is a problem from my side or migrate side ?

Make airports optional for bookings

There are cases where a admin wants to create bookings, but don't want to require either departure or arrival airport.

The easy fix is to create a dummy airport 'ZZZZ', but it would be better if admin doesn't have to fill anything in there

Replace own jQuery code with Alpine

In #122 , I replaced the the datepickers (jQueryUI) with flatpickr + Alpine.js. It would be nice to get rid of jQuery within the rest of the views.

Note to self: Do this after #432 to reduce potential unneeded work

Notifications in Front-End

Not everybody will use e-mails, making most notifications useless. I think it's best to add notifications in the front-end.

The table already exists (and I checked, no difference from 5.6 to 7), so only 2 things need to be done:

  • Notifications not triggered by user, add database to via
  • Create something in the navbar so users can actually read the notifications

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.