david20122 / sound-space-plus Goto Github PK

qw

Tested on Archlinux, Kernel 6.3.9-arch1-1

libdiscord-game-sdk-godot.so causes the game to crash on Startup on the Linux build, a problem not seen in Windows. Running an LDD on the file shows it can't find the libdiscord_game_sdk.so dependency.

Results for ldd libdiscord-game-sdk-godot.so:

$ ldd libdiscord-game-sdk-godot.so
ldd: warning: you do not have execution permission for `./libdiscord-game-sdk-godot.so'
	linux-vdso.so.1 (0x00007fffd43e0000)
	libdiscord_game_sdk.so => not found
	libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f8270600000)
	libm.so.6 => /usr/lib/libm.so.6 (0x00007f8270913000)
	libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f82708ee000)
	libc.so.6 => /usr/lib/libc.so.6 (0x00007f8270416000)
	/usr/lib64/ld-linux-x86-64.so.2 (0x00007f8270d77000)

The libdiscord-game-sdk file seems to be searching for libdiscord_game_sdk.so, but in the discord_sdk.gdnlib files in addons/discord_game_sdk shows the dependency is named discord_game_sdk.so (View below)

https://github.com/krmeet/sound-space-plus/blob/c930b2bc7cd2e5ecc02f0f243a4c1addfd3d467e/addons/discord_game_sdk/discord_sdk.gdnlib#L18

Error log:

ERROR: Can't open dynamic library: addons/discord_game_sdk/libdiscord-game-sdk-godot.so. Error: libdiscord_game_sdk.so: cannot open shared object file: No such file or directory
   at: open_dynamic_library (drivers/unix/os_unix.cpp:418)
ERROR: No valid library handle, can't get symbol from GDNative object
   at: get_symbol (modules/gdnative/gdnative.cpp:510)
ERROR: No nativescript_init in "res://addons/discord_game_sdk/libdiscord-game-sdk-godot.so" found
   at: init_library (modules/gdnative/nativescript/nativescript.cpp:1503)
ERROR: Reference to a Thread object was lost while the thread is still running...
   at: ~_Thread (core/bind/core_bind.cpp:2802)

(Close when done)

• Menu music overlaps with unused music from CM

I am unsure what the exact strat this project is currently using is, but I have used a similar strat in the past(main and dev branch, compared with this project's stable and nightly). as shown below:

gitGraph
commit
commit

branch nightly
commit
commit

branch pr1
commit
commit

checkout nightly
commit

checkout pr1
commit

checkout nightly
commit
merge pr1

checkout main
merge nightly tag: "Release 1"

checkout nightly
commit
commit

checkout main
merge nightly tag: "Release 2"

Note: I have no idea wtf rewrite stems from

I used to use this strat but I found this strat annoying to use and now I also find it confusing, looking at this repo and not knowing which branch I should PR into. I would like to propose using the same branching strat as Godot's repository since it is simpler to use and makes more sense in my opinion.

Godot's branching strat works by using the main branch for everything. When a new major version is released, a tag and a branch will be created from the commit used for the new major release. The branch will then be used for minor and patch releases while the master branch continues being developed.