davidiq / reimg Goto Github PK

http://www.phpbb.com/community/viewtopic.php?p=12578035#p12578035

Depending on what the differences really are, add Lytebox support.

http://flowplayer.org/tools/demos/overlay/apple.html
Looks to be a lot smoother than HighSlide JS. Licensed under GPLv3 so will not be able to include it. Will just use same method as was used for HighSlide JS.

This is the basic implementation to be replaced with an actual config option.
In includes/functions.php:

     function reimg_properties()
     {
        global $config;
        return 'class="reimg" onload="reimg(this);" onerror="reimg(this);" ' . (($config['reimg_zoom'] == '_highslide') ? 'onmouseover="return hs.expand(this);" ' : '');
     }

In reimg_content.html:
After hs.lang.restoreTitle = "{LA_RESTORE_TITLE}";

     hs.Expander.prototype.onMouseOut = function (sender) {
        sender.close();
     };

Move all settings out of the posting area and place in .MODS tab under separate ACP panel. Will reduce the amount of edits required for this MOD but would also add UMIL.

This will apply to Highslide JS (already a feature) and to Lytebox when added.

At this point not sure yet what images should be in the slideshow. Could go by the reimg css class for doing this I bet. But it would be hard to not include all images on the page that have been resized...

When zoomed into the image the horizontal scrollbar is offscreen making it impossible to scroll left/right to view the entire image.

Example:
http://phpbb.davidiq.com/viewtopic.php?f=9&t=353#p1480

I just upgraded my 3.0.14 board to the latest 3.3.11. It was really painful because of lots of modifications were lost, and I'm trying to restore the most important ones.

I found that here is ReIMG Image Resizer extension port compatible with 3.3, so I tried to install it.

I can see admin settings (unfortunately, my language is not supported by this port, but it is not a big problem), but I don't see any changes in images in posts. Should it be working with 3.3.11 at all? Maybe there is some global on/off switch which I could miss?

Can you please add lightbox support? And have it the same layout that they have theirs?

Magnific Popup permits mixed content when scrolling through objects - video as well as images can be presented in a popup. Please make provision for this feature when you enable Magnific Popup.

Thanks
Dan

Where does latest release version is located? Here https://github.com/DavidIQ/phpBB-ReIMG-Image-Resizer#installation link points download from master branch. Master branch is latest released version? Is it stable enough to install in forums?

[phpBB Debug] PHP Notice: in file /includes/functions_reimg.php on line 48: Invalid argument supplied for foreach()
[phpBB Debug] PHP Notice: in file /includes/functions_reimg.php on line 67: Invalid argument supplied for foreach()
[phpBB Debug] PHP Notice: in file /adm/index.php on line 150: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3706)
[phpBB Debug] PHP Notice: in file /adm/index.php on line 152: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3706)
[phpBB Debug] PHP Notice: in file /adm/index.php on line 153: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3706)
[phpBB Debug] PHP Notice: in file /adm/index.php on line 154: Cannot modify header information - headers already sent by (output started at /includes/functions.php:3706)

Seems to happen when language entries are not found. Need to have it do a fallback.

Referencing this post: http://www.phpbb.com/customise/db/mod/reimg_image_resizer/support/reimg_in_internet_explorer_9_rc-t_90262-p_212878#p212878
and this link: https://github.com/DavidIQ/phpBB-ReIMG-Image-Resizer/tree/2.0.0

The link is 404'd and I don't see branch 2.0.0 any longer. Do you have a specific commit which fixes this?
If you don't, I would be more than happy to debug, fork, and issue a pull request to fix if you don't have the time and it hasn't been addressed.

Just wanted to check with you first before taking the time to find the bug.

Thanks,
slickplaid

Also, IE9 version 9.0.8112.16421 was used to verify this issue.

https://www.phpbb.com/community/viewtopic.php?p=14854636#p14854636

Maybe in a forum like this one that is not max width, it's ok to have an image to show the full size, but in a forum that is Max width the full image is too big and is not good user experience.

[phpBB Debug] PHP Notice: in file [ROOT]/includes/functions_reimg.php on line 138: Array to string conversion

Line 138: $images = array_unique($images);

More info: https://www.phpbb.com/customise/db/mod/reimg_image_resizer/support/php_error-t_100356

As per: http://www.phpbb.com/customise/db/mod/reimg_image_resizer/support/issue_with_signatures-t_95669

"In Version 2.0.1 even if in the ACP "Ignore images in signatures:" is set to "Yes" the attributes for [c]onerror[/c], [c]onload[/c] are set to the images in signatures. If "Ignore images in signatures:" is set to "No" they are applied 2 times"

In debug mode with ReIMG Image Resizer 2.0.1 while moving a topic to another forum:

File: /includes/hooks/hook_reimg.phpLine: 126
Message: Undefined index: SIGNATURE

It is a desirable feature to apply resizing to the image upon upload. The options to have available are:

• Automatic down-sizing of image to configured resolution
• If it's a PNG, conversion to JPG
• Saving as JPG with configured JPG-quality setting
• Option to remove EXIF data
• One-click import function (?)
• Optional Watermarking

http://phpbb.davidiq.com/viewtopic.php?p=1563#p1563
The image is 640x167. When initially zoomed in it looks ok. On the final zoom-in there is white space being padded onto the bottom of the modal pop-up.

Instructions for making this MOD work on other pages outside of phpBB, i.e. a portal page, are not working as designed. Need to create a different approach for doing that.

In hook_reimg.php line 106:
if (isset($data['SIGNATURE']) && reimg_get_config('reimg_ignore_sig_img', false) == true)

This line should have been:
if (isset($data['SIGNATURE']) && reimg_get_config('reimg_ignore_sig_img', false) == false)

When a user creates a post while one is authoring their own post the images are not being resized:

http://www.phpbb.com/customise/db/mod/reimg_image_resizer/support/bug_when_people_post_while_you_are_writing_a_post-t_97848

It's yellow right now and it's ugly.

When viewing message details in the MCP images are not resized.