daviferreira / react-component-starter-kit Goto Github PK

First of all I wanted to say that I really like your repo. Awesome work!

I was thinking that maybe adding .npmignore would be very beneficial to the project. I do not believe you want to pull demo/ or test/ folder when you install React component.

Any thoughts on this ?

I just wondering if test/ folder is the best location for the test files. In a relatively small component it is not a big deal. But for a fairly complex component with many files within the src/ folder can get very ugly. Maybe it is the best to keep test files in test/ directory.

Any thoughts ?

Most often React component come with supplementary style sheet files like CSS or, even more often, SCSS or LESS which have to be transpiled into CSS. It would be awesome if you could add some basic samples in this project for anyone who is facing a similar challenge.

You have a great .npmignore file. I thought that it possibly could be better if you use default Node.js npmignore file provided by GitHub. I believe the content of it something like that.

# Logs
logs
*.log
npm-debug.log*

# Runtime data
pids
*.pid
*.seed

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directory
node_modules

# Optional npm cache directory
.npm

# Optional REPL history
.node_repl_history