[Enhancement]: Allow enrich to return `nil` about re-frame HOT 7 CLOSED

Yes, a PR would be great. Thanks!

from re-frame.

Sorry @NoahTheDuke I misread the issue/code when I posted my previous comment. The PR that has been merged is a sufficient solution 👍🏻

from re-frame.

Thanks for the report. Re 3. logging with (re-frame.loggers/console :error ...) might be more appropriate than throwing ?

from re-frame.

@superstructor Yeah, I intended these to be 3 separate potential solutions, not a single giant solution. I can implement whichever you'd like, just let me know.

from re-frame.

@NoahTheDuke agree with all. I think we should log the error instead of throw it. Look forward to the PR 👍🏻

from re-frame.

Reopened as #751 implemented 1. but at least 2. (logging) still needs to be done.

from re-frame.

I wrote the docs in my PR under the assumption that returning nil would be an expected behavior, so what kind of logging would you like? I feel like a :warn wouldn't be appropriate, given that I will be relying on this behavior deliberately in a somewhat high-volume code path.

from re-frame.