Giter VIP home page Giter VIP logo

Comments (2)

kimo-k avatar kimo-k commented on August 16, 2024 1

Hey @joshcho, interesting problem.

I considered changing the :id to include a hash of the args, but I think this would interfere with the simplicity of the library. Not all names in std-interceptors are factories, some are values. It's not so nice to have to hold onto an auto-generated id if you want to clear the interceptor later, or select it somehow. Dealing with extra arities or option maps for the id isn't so nice either.

While it would be nice if this just worked, I think it's okay to consider your use-case non-standard. I added some documentation for it.

If you'd like the ergonomics in your first example, consider:

(defn my-on-changes [& args]
  (-> (apply rf/on-changes args)
      (update :id #(keyword (str (name %) "__" (hash args))))))

from re-frame.

joshcho avatar joshcho commented on August 16, 2024

The workaround I am using at the moment is specifying the id like so:

(defn my-on-changes
  [interceptor-id & rest]
  (assoc (apply rf/on-changes rest)
         :id interceptor-id))

It also seems like with this method, the interceptors are applied in reverse order.

from re-frame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.