daybrush / css-styled Goto Github PK

the creact-css-styled packages imports the croact package but the package.json does not have croact in dependencies, only in devDependencies. this causes problems.

how to reproduce the problem:

1. npm init
2. npm add croact-css-styled
3. run node, and inside run require('croact-css-styled')
   you get this error-message:

Uncaught Error: Cannot find module 'croact'
Require stack:
- .../node_modules/croact-css-styled/dist/styled.cjs.js

(in this case you can workaround it by just installing croact, but if you use yarn for example, which only allows loading code from packages that your package depends on, it becomes a harder problem)

The following commit cause an issue in project using this library:
ac6a2b3

Line that causes the issue:
ac6a2b3#diff-0e825ed2f2470d57c43b731b2eea9bbf05aef8e9d1e091b017b56ecd094609eaR22

My situation: I am using the library moveable in a non-react app.
Since there is no react version, its value is undefined so it crashes when doing .indexOf (cannot read indexOf of undefined)

@daybrush Could you check if the version exists before doing the indexOf ? Like:
if ((version ?? '').indexOf("simple") > -1 && portalContainer) {

Thank you

"export 'version' was not found in 'react-simple-compat'
@ ./node_modules/react-compat-moveable/dist/moveable.esm.js

you wanted a bug report, here it comes ;-)

The link to the API docs from ReadMe.md points to "https://daybrush.com/css-styled/release/latest/doc/" which does not exist.

I've found that this library generates an error when used with React's strict mode. It looks like it would be straightforward to fix - this code just needs to be switched to using refs instead of using findDOMNode.

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Styler which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
    in div (created by Styler)
    in Styler (created by MoveableManager)
    in MoveableManager (created by Moveable)
    in Moveable