dazwilkin / rust-googleapis Goto Github PK

If any build step fails, the crate build, fails. This is good.

However, the way I've structured build.rs is fragile.

E.g.:

Could not make proto path relative: googleapis/google/type/quarternion.proto: ...
thread 'main' panicked at 'protoc: ...

This is because in build.rs, I'd mistyped quaternion (one r not 2)

Solution:

1. Better to emulate protoc .... *.proto to catch everything not just those specified
2. The list must be duplicated in each mod.rs and this should be auto-generated

Rerunning cargo build fails if the clone directory exists.

Check for existence and handle it.

This is particularly bothersome for crates that reference this crate.

The repo requires protoc for 2 reasons:

• build.rs
• protobuf well-known types

For the build.rs, as long as crates that depend upon this, have protoc in the path, all's good.

But for the well-known types, these must be present.

Because I've been unable to get the protobuf crate's well-known types working correctly, I need these cloned too.

Perhaps clone these types from their source too?

I've switched to, e.g:

match Repository::clone(
    "https://github.com/googleapis/googleapis.git",
    Path::new(googleapis),
) {
    Ok(_) => {
        println!("[{}] cloned", googleapis);
        google::api();
        google::rpc();
        google::container();
        google::iam();
        google::cloud::iot();
        grafeas::v1();
    }
    Err(e) => match e.code() {
        ErrorCode::Exists => println!("[{}] exists", googleapis),
        _ => panic!(
            "[{}] unexpected: {:?} {:?}",
            googleapis,
            e.code(),
            e.message()
        ),
    },
}

The fns e.g. google::api() are now explicitly called within the Ok branch of the Result.

This is because, it appears (!) that the clone command doesn't block entirely on the completion of the git clone. If e.g. google::api() is placed after the clone, it occasionally fails.

Placing e.g. google::api() within the match block means that the protoc is only run if the directory did not exist when the build.rs was run.