dbachelder / creditcardentry Goto Github PK

Zipcodes in Canada have letters in them and they are 6 digits. Can the zip code field be updated to allow for this?

Text color of textbox not showing black first time

@wikichen do you have a good way to show the distinction between the standard "here is where the CVN is" image and the amex way (it's always on the front of the card)

https://github.com/dbachelder/CreditCardEntry/blob/master/CreditCardEntry/res/drawable-xhdpi/amex_back.png

Right now I'm using the standard back of the card for everything..

requestFocus() doesn't work. How set request focus and open keyboard.

Lots of failures of the type:

AGPBI: {"kind":"error","text":"error: \u003citem\u003e inner element must either be a resource reference or empty.","sources":[{"file":"/Users/XXXX/.gradle/caches/transforms-1/files-1.1/CreditCardEntry-1.4.7.aar/a4f38cbb1d005ade4b971a4553de5145/res/values/values.xml","position":{"startLine":11,"startColumn":4,"startOffset":988,"endColumn":46,"endOffset":1030}}],"original":"","tool":"AAPT"}

Not really too sure how to proceed.

Is there a way to increase the size of the font? I'm on a tablet and it seems too small.

@jgrana want to transfer ownership to me so I can manage members and integrations and whatnot?

After you enter the 16 numbers, only 4 are shown, with the first 12 being hidden. Very cool!

However, I think it would be a bit more obvious to users if the first 12 digits were replaced with 'dots' (or some such symbol) to make it really obvious that the card was entered successfully and that we're only hiding numbers from them as a security measure.

Would something like this be possible? I've seen it elsewhere and it felt more user friendly. Perhaps configurable with a true/false attribute?

When I added this paths to my gradle file it will show error message telling "Failed to resolve:com.github.dbachelder:CreditCardEntry:v1.3.0" like that.

Mainly is there an option to not have a background resource on the linear layout and one to add a background resource to the edit text field?

I set the credit card form including three field: number, exp date and security code.
Finish entering these three field, the cursor will move to last digit of credit card number.

Project contains <item name="null_color" type="color">234234</item> which causes build to fail on Android Studio 3.0 with

Error: invalid color

Using a Galaxy Note 5.

I entered "424242424242...." and then it scrolls over, but it ends up glitched as shown

When typed in the expired date, the helper text was "Expiration date (MM/DD)".
I guess it should be "MM/YY". :)

Type in valid card number on credit-card entry page.
Type in credit card expiration date of current month is not allowed.

When typing a card number on android 5.0.2 I am unable to delete it.

Hi,

In my XML I'm using 'android:padding="15dp"' on the CardForm, however it seems to be adding a margin around the entire view. Is there a way I can set the padding in XML between the white background and the text, to make the input field bigger? I would like the ability to add different paddings for different screen sizes, but I can handle that bit as long as I find a way to actually adjust the padding.

Is this a bug or something I'm just missing?

Thanks.

After the form is correctly filled out, and isCreditCardValid correctly returns true, I'm able to click on the credit card number, erase a bunch of the numbers (thus rendering the number incorrect), focus on some other field on the screen, and have isCreditCardValid still return true (when, in fact, I had expected it to return false).

I'm working with Stripe, which went on to fail because the data in the CreditCardForm was actually invalid at that point.

It is causing a really unnessary error for me:
Error:(46, 9) Attribute application@icon value=(@drawable/halplogo) from AndroidManifest.xml:46:9
Error:(46, 9) Execution failed for task ':app:processDebugManifest'.

Manifest merger failed : Attribute application@icon value=(@drawable/halplogo) from AndroidManifest.xml:46:9
is also present at com.github.dbachelder:CreditCardEntry:v1.2.1:13:9 value=(@drawable/ic_launcher)
Suggestion: add 'tools:replace="android:icon"' to element at AndroidManifest.xml:44:5 to override

I have added tools:replace="android:icon" in application but I still get the error. It would be awesome if you could just delete that line since there is no point in a library having an icon. Thanks man!

ERROR: Failed to resolve: com.github.dbachelder:CreditCardEntry:1.4.7

Hi ! I wanted to know if there is a possibility to disable the zip entry of the card entry ?
And is there a possibility to customize input, such as background, input borders... ?
Thanks ;)

To reproduce:
Type in credit card number -> component scrolls and focuses into expiration date.

Expected:
I can type expiration date and component keeps its "state" and doesn't scroll away from the expiration date while typing

Actual:
When typing, component scrolls into the credit card number but cursor still seems to remain in expiration date.

Save behaviour is also repeated with CCV. I have reproduced this with the example app.

Only found one device which reproduces this: Sony Xperia XA (F3111 with Android version 7.0). Sadly couldn't find a virtual device setup where this could be reproduced.

Could not see any obvious reason by debugging, why this is happening. Any idea?

Currently the strings for this project are available in English only.
It would be nice to have support for other languages as well.

I have a button named "commit", it's disable when activity create, which should change status decide on card valid.

Can you add setError function similar to EditText set error for showing error messages in the view?

Thanks,

The only reason I can't use this library is because our app is using a font and there doesn't seem to be a way to apply fonts in CreditCardForm. At least let CreditCardForm return actual underlying TextViews so that user can apply fonts on it.

Hi,

I'm using this amazing library (thanks for that;) and I'm concerned about how to give an already filled version of the form, from the second time the user visualizes it. (when I already have the data).

thanks a lot and congrats for the tool
;)

I am making the view visible at one condition, at that time I want the soft keypad open without touching the editbox. How to make this.

the credit card validation works fantastic .. BUT i want to separate CC card number, CVV and expiry month in 3 different edit text.

How to do this?
Any suggestion will be great helpful for me.

i want to create form with all fields separate,
=>Card number
=>Exp data
=>CCV

I am facing this weird issue in which my UI goes under-screen when focused.
I am using it inside a horizontal ScrollView.

Any idea what's happening?

In my code I need to enable/disable 'save card' button dynamically.
Case:
I can disable 'save card' button by default, and then enable it when card became valid (from callback). But if user will edit the card info then - it may became invalid, and there is no way to know about it, while user types. I think I can do it in 'hacky' way, but no reason for this :) Please provide such callback.

I have CreditCardForm in my xml and it shows up in the view, but when I tap it nothing happens, no soft keyboard or anything.

<com.devmarvel.creditcardentry.library.CreditCardForm
            android:layout_marginLeft="@dimen/pad4"
            android:layout_marginRight="@dimen/pad4"
            android:layout_marginTop="@dimen/pad8"
            android:layout_marginBottom="@dimen/pad8"
            android:id="@+id/cc_input"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            app:include_exp="false"
            app:include_helper="false"
            app:include_security="false"
            app:include_zip="false"/>

Any idea what might be the issue?
p.s: it's inside a recyclerview.

the library throws an error when typing in cards starting with 3116

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'.
It will be removed at the end of 2018. For more information see: http://d.android.com/r/tools/update-dependency-configurations.html

Failed to resolve: compile 'com.github.dbachelder:CreditCardEntry:1.4.0'

repositories{
  maven { url "https://jitpack.io" }
}

Have you noticed that when using this library that the field to enter the details has a weird margin/padding around it?

I want to be able to put another EditText right below this view with no spaces and it won't let me. It has a padding/margin somewhere that is sticks too.

I can't seem to find anywhere in the code to change this, do you know where I can change it in the library?

It looks very weird, because this view sits at the top of my layout, then there's a gap and all my other EditTexts are below that gap, but that are sitting close to each other with no margins or padding.

5388 4105 5057 8191
10/32 CVV:191

Originally posted by @EXTRA5POWER in sbycrosz/react-native-credit-card-input#226

> Task :app:checkDebugDuplicateClasses FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.
> 1 exception was raised by workers:
  java.lang.RuntimeException: java.lang.RuntimeException: Duplicate class com.devmarvel.creditcardentry.BuildConfig found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.CreditCardText found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.CreditEntryFieldBase found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.CreditEntryFieldBase$BackInputConnection found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.ExpDateText found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.SecurityCodeText found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.fields.ZipCodeText found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$1 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$2 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$3 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$4 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$5 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$6 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$7 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$8 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$SavedState found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardEntry$SavedState$1 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardFieldDelegate found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardUtil found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.CreditCardUtil$1 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.internal.FlipAnimator found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CardRegex found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CardType found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CardValidCallback found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CreditCard found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CreditCardForm found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CreditCardForm$1 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CreditCardForm$SavedState found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)
  Duplicate class com.devmarvel.creditcardentry.library.CreditCardForm$SavedState$1 found in modules classes.jar (com.github.dbachelder:CreditCardEntry:1.4.9) and classes.jar (com.github.tipsi:CreditCardEntry:1.5.1)

Looks like a huge number of the classes are duplicated between the two libraries and I'm not sure how to deal with it.

Hi!

I'm having problems when I set the credit card number in the form:
This is if I don't focus the credit card number:

And this is after focus the credit card number

If I enter a CVV it will validate it right.

Very nice library btw.
Regards

The credit card entry form doesn't really fit in when it is placed in an application with a dark theme. The defaults for app:cursor_color, app:text_color, app:input_background, etc. are dark colors and are not very visible on dark themes. It's possible to manually set these colors, but it would be nicer if the widget just used the default colors that are provided by the theme.

I tried going through and just removing the places where the underlying EditTexts have colors assigned, and it worked pretty well for me.

diff --git a/CreditCardEntry/src/com/devmarvel/creditcardentry/fields/CreditEntryFieldBase.java b/CreditCardEntry/src/com/devmarvel/creditcardentry/fields/CreditEntryFieldBase.java
index 064b1b9..de368a8 100644
--- a/CreditCardEntry/src/com/devmarvel/creditcardentry/fields/CreditEntryFieldBase.java
+++ b/CreditCardEntry/src/com/devmarvel/creditcardentry/fields/CreditEntryFieldBase.java
@@ -82,9 +82,9 @@ public abstract class CreditEntryFieldBase extends EditText implements
        }

        TypedArray typedArray = context.obtainStyledAttributes(attrs, R.styleable.CreditCardForm);
-       setTextColor(typedArray.getColor(R.styleable.CreditCardForm_text_color, Color.BLACK));
-       setHintTextColor(typedArray.getColor(R.styleable.CreditCardForm_hint_text_color, Color.LTGRAY));
-       setCursorDrawableColor(typedArray.getColor(R.styleable.CreditCardForm_cursor_color, Color.BLACK));
+//     setTextColor(typedArray.getColor(R.styleable.CreditCardForm_text_color, Color.BLACK));
+//     setHintTextColor(typedArray.getColor(R.styleable.CreditCardForm_hint_text_color, Color.LTGRAY));
+//     setCursorDrawableColor(typedArray.getColor(R.styleable.CreditCardForm_cursor_color, Color.BLACK));
        typedArray.recycle();
    }

diff --git a/CreditCardEntry/src/com/devmarvel/creditcardentry/internal/CreditCardEntry.java b/CreditCardEntry/src/com/devmarvel/creditcardentry/internal/CreditCardEntry.java
index 6987b28..e586971 100644
--- a/CreditCardEntry/src/com/devmarvel/creditcardentry/internal/CreditCardEntry.java
+++ b/CreditCardEntry/src/com/devmarvel/creditcardentry/internal/CreditCardEntry.java
@@ -86,7 +86,7 @@ public class CreditCardEntry extends HorizontalScrollView implements
         this.context = context;

         TypedArray typedArray = context.getTheme().obtainStyledAttributes(attrs, R.styleable.CreditCardForm, 0, 0);
-        textColor = typedArray.getColor(R.styleable.CreditCardForm_text_color, Color.BLACK);
+//        textColor = typedArray.getColor(R.styleable.CreditCardForm_text_color, Color.BLACK);
         typedArray.recycle();

         WindowManager wm = (WindowManager) context.getSystemService(Context.WINDOW_SERVICE);
@@ -123,7 +123,8 @@ public class CreditCardEntry extends HorizontalScrollView implements

         textFourDigits = new TextView(context);
         textFourDigits.setTextSize(20);
-        textFourDigits.setTextColor(textColor);
+        textColor = textFourDigits.getCurrentTextColor();
+//        textFourDigits.setTextColor(textColor);
         container.addView(textFourDigits);

         expDateText = new ExpDateText(context, attrs);

MasterCard has announced that they will add a new 2 series BIN range effective October 2016. The BIN range (222100-272099) will be processed with and in the same manner as the existing 51-55 BIN range (510000-559999).

https://www.forte.net/blog/mastercard-bin-range-coming/

@dbachelder
I think it would be nice to add this new range to this great project. What do you guys think?

<com.devmarvel.creditcardentry.library.CreditCardForm
        android:id="@+id/credit_card_form"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        app:helper_text_color="@color/rosaXceed"
        app:input_background="@drawable/input_credit_card"
        app:include_helper="false"
        app:include_zip="false"
        app:include_exp="false"
        app:include_security="false"/>

And this is the code

 Form = (CreditCardForm) findViewById(R.id.credit_card_form); 
 Form.setCardNumber("4242 4242 4242 4242", false)

If I put without setCardNumber() all works. But If I put it, app crashes with this error
04-26 00:52:53.532 6585-6585/me.xceed.xceed E/AndroidRuntime﹕ FATAL EXCEPTION: main
Process: me.xceed.xceed, PID: 6585
java.lang.RuntimeException: Unable to start activity ComponentInfo{me.xceed.xceed/me.xceed.xceed.AddCreditCardActivity}: java.lang.IndexOutOfBoundsException: setSpan (3 ... 3) ends beyond length 0
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2658)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2723)
at android.app.ActivityThread.access$900(ActivityThread.java:172)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1422)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5832)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)
Caused by: java.lang.IndexOutOfBoundsException: setSpan (3 ... 3) ends beyond length 0
at android.text.SpannableStringBuilder.checkRange(SpannableStringBuilder.java:1022)
at android.text.SpannableStringBuilder.setSpan(SpannableStringBuilder.java:615)
at android.text.SpannableStringBuilder.setSpan(SpannableStringBuilder.java:611)
at android.text.Selection.setSelection(Selection.java:123)
at android.text.Selection.setSelection(Selection.java:134)
at android.widget.EditText.setSelection(EditText.java:115)
at com.devmarvel.creditcardentry.fields.CreditCardText.afterTextChanged(CreditCardText.java:55)
at android.widget.TextView.sendAfterTextChanged(TextView.java:8615)
at android.widget.TextView.setText(TextView.java:4645)
at android.widget.TextView.setText(TextView.java:4489)
at android.widget.EditText.setText(EditText.java:101)
at android.widget.TextView.setText(TextView.java:4464)
at com.devmarvel.creditcardentry.internal.CreditCardEntry.setCardNumber(CreditCardEntry.java:346)
at com.devmarvel.creditcardentry.library.CreditCardForm.setCardNumber(CreditCardForm.java:211)
at me.xceed.xceed.AddCreditCardActivity.onCreate(AddCreditCardActivity.java:44)
at android.app.Activity.performCreate(Activity.java:6221)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1119)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2611)
            at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2723)
            at android.app.ActivityThread.access$900(ActivityThread.java:172)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1422)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:145)
            at android.app.ActivityThread.main(ActivityThread.java:5832)
            at java.lang.reflect.Method.invoke(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:372)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1399)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1194)

I have noticed that we I set the view to android:visibility="invisible" in the layout and then later make it visible via code. The view will display, but I can't seem to focus on it or tap on the view to try and enter data.

However, you can programmatically make the view "GONE" or "INVISIBLE" and then later make is visible. I'm using android version 6 on a nexus 6p is that helps. I haven't dug into the source code to find the problem because there's an easy work around but it might be worth having it documented as a issue for other too see.