dbjorkholm / forgottenserver Goto Github PK

Utito tempo player attacks but inflicts blows

Shop module doesn't work.
Just try to summon Eryn or Deruno. Both have it scripted different way, noone works.

@ninjalulz or another member

Can anyone update for the 8.70 protocol?
Whenever I try to use the 8.70 client, the client debug.
I just need to be able to log in to version 8.70

Heal Friend BUG
Exura Sio is bugged. It heals 1 sqm in front of the caster - not the target.
http://oi68.tinypic.com/aff2ie.jpg
You can also cast exura sio without the target
http://oi65.tinypic.com/2iide28.jpg

Is it possible to compile this in visual studio 2019? If so how?

Missing codes in source so it is possible to use groupcooldow.
This tag is used in spells.xml
Ex: groupcooldown="2000"

----- 29/02/2016 21:26:32 - Seven (191.187.54.131) -----
Debug Assertion 8.0 Communication.cpp 1765
Tue Mar 01 00:26:30 2016
Windows Version: 6.1 build 7600 on 2
Graphic Engine: DirectX9 (2)
Last Packet Types: 109 109 109 109 109 109 110 131 143 109
Last Packet: 058 000 109 133 129 132 123 015 001 133 129 131 123 015 160 150
Player Position: [33154,31620,15]
Player Name: Seven
Player.cpp 358: exception occurred, reason:
Network.cpp 980: exception occurred (ErrorCode = 0), reason:
Control.cpp 1309: exception occurred (Type = 109), reason:
Communication.cpp 1994: exception occurred, reason:
Communication.cpp 1765: Player object is not where it should be, reason:
hx: 8 hy: 6 hz: 2
Cylinder (1): (410,0) (99,1073760013)
Cylinder (2): (410,0) (99,1073760013)(-)(-)(-)(-)(-)(-)(-)(-)
Comment:

xx.xxx.xxx.xxx disconnected for exceeding packet per second limit.

I know that I can simply just change value in config, but as i remember in older versions of TFS, only gm could make packet limit by spamming spells ( no cd ).
In this version everyone who hold the hotkey (for example potion) is going to be kicked

Item ID: 1811
Item ID: 1818
Item ID: 1429
Item ID: 1431
Item ID: 1432
Item ID: 1433
Item ID: 1434

First - thanks for fixing the NPCs/spells/monsters, thats a lot of awesome work! Second - while I was testing some changes today with my cousin, by accident we noticed that NPC dialogue is visible only to the player who started the talk (said "hi"), which I think is invalid because NPCs talk in Default Channel now, so it should be visible to everyone. I tried to fix this, but I'm complete newbie at programming and I obviously failed. It was tested on a server downloaded and compiled about 20 hours ago.

Debug Assertion 8.0 Communication.cpp 2551
Tue Mar 01 18:51:45 2016
Windows Version: 6.1 build 7600 on 2
Graphic Engine: DirectX9 (2)
Last Packet Types: 170 170 170 030 030 030 030 104 109 104
Last Packet: 072 000 170 014 000 000 000 004 000 069 114 121 110 000 000 000
Player Position: [32356,32215,7]
Player Name: Seven
Player.cpp 358: exception occurred, reason:
Network.cpp 980: exception occurred (ErrorCode = 0), reason:
Control.cpp 1309: exception occurred (Type = 170), reason:
Communication.cpp 2556: exception occurred (Mode = 0) (Channel = 0), reason:
Communication.cpp 2551: unknown talk mode (Mode = 0), reason:
[bug0000649]

Ladders doesn't work when there is any item over it.

(ps sorry for green areas, some recording error)

when will be realeased a new version of tfs 1.3 for 8.6 ots @ninjalulz

On the 8.0 branch: when I talk to an npc and say "buy 200 arrows" he just gives me 100 arrows. How can I support selling more than 100 items?

function doNpcSellItem(cid, itemId, amount, subType, ignoreCap, inBackpacks, backpack)
	local amount = amount or 1
	local subType = subType or 0
	local item = 0
	local player = Player(cid)
	if ItemType(itemId):isStackable() then
		local stuff
		if inBackpacks then
			stuff = Game.createItem(backpack, 1)
			item = stuff:addItem(itemId, math.min(100, amount))
		else
			stuff = Game.createItem(itemId, math.min(100, amount))
		end

		return player:addItemEx(stuff, ignoreCap) ~= RETURNVALUE_NOERROR and 0 or amount, 0
	end

	local a = 0
	if inBackpacks then
		local container, itemType, b = Game.createItem(backpack, 1), ItemType(backpack), 1
		for i = 1, amount do
			local item = container:addItem(itemId, subType)
			if isInArray({(itemType:getCapacity() * b), amount}, i) then
				if player:addItemEx(container, ignoreCap) ~= RETURNVALUE_NOERROR then
					b = b - 1
					break
				end

				a = i
				if amount > i then
					container = Game.createItem(backpack, 1)
					b = b + 1
				end
			end
		end

		return a, b
	end

	for i = 1, amount do -- normal method for non-stackable items
		local item = Game.createItem(itemId, subType)
		if player:addItemEx(item, ignoreCap) ~= RETURNVALUE_NOERROR then
			break
		end
		a = i
	end
	return a, 0
end

Although my character is in guild which you can see in description there is no guild banner near name.

https://d3higte790sj35.cloudfront.net/images/rb/iy/2c176cd558ba76d06b560bac818c5957.png

Blue/red/green banner appears when your guild is in war with another one. But as i remember, there were also banner without war, at least it is in nowadays tibia, maybe it was missing in 8.6

Get debug when use command /ghost, but when i back, im invisible.

----- 01/03/2016 19:33:29 - Seven (191.187.54.131) -----
Debug Assertion 8.0 Container.h 226
Tue Mar 01 22:33:42 2016
Windows Version: 6.1 build 7600 on 2
Graphic Engine: DirectX9 (2)
Last Packet Types: 131 180 142 132 131 140 109 109 109 109
Last Packet: 042 000 142 002 000 000 016 000 000 000 000 180 022 022 000 089
Player Position: [33135,31629,14]
Player Name: Seven
Player.cpp 358: exception occurred, reason:
Player.cpp 460: exception occurred, reason:
Control.cpp 1633: exception occurred (MessageType: 0 MaW: 7C7D78 MoW: 0), reason:
Control.cpp 1628: exception occurred, reason:
Control.cpp 379: exception occurred (Force?1:0 = 0), reason:
MainWindow.cpp 133: exception occurred (Surface = 1), reason:
GUI.cpp 1452: exception occurred (Surface = 1), reason:
MapWindow.cpp 861: exception occurred (Surface = 1), reason:
MapWindow.cpp 548: exception occurred (Obj = 0), reason:
MapWindow.cpp 1113: exception occurred (posx = 224) (posy = 160), reason:
MapWindow.cpp 1105: exception occurred (EffectNumber = 5) (Type = 0), reason:
Objects.cpp 691: exception occurred (Number = 0), reason:
Container.h 226: index out of range (original i: 0, i: -1, min: 1, d: 69)
Comment:

Someone reported me that sending parcel to offline player make it disappear.
He uses this engine downgraded to 8.0.

Fix

Under:
https://github.com/ninjalulz/forgottenserver/blob/8.0/src/mailbox.cpp#L125
Paste:

tmpPlayer.setLastDepotId(depotLocker->getDepotId());

EDIT:
I'm not sure if it saves parcel when you send it to person that is online, but do not open depot and logouts. Waiting for answer:
https://otland.net/threads/parcel-system.262519/#post-2540928

// Gesior.pl at work