dbrekalo / json-api-normalize Goto Github PK

example

{
"relationships": {
"field_test": {
"data": [
{
"type": "paragraph--image",
"id": "456"
},
{
"type": "paragraph--text",
"id": "123"
}
]
}
}
}

First of all I want to say thank you for creating such neat package 🙇

Unfortunately I found a little bug using it. As it is stated in the title, If data.attributes contains type property (data.attributes.type) it is being overridden by type in data object (data.type)

As is:

const jsonApiNormalize = require('json-api-normalize');

const input = {
    data: {
        type: 'article', // <--
        id: '1',
        attributes: {
            type: 'other type' // <--

            title: 'JSON API paints my bikeshed!',
            body: 'The shortest article. Ever.',
        },
    },
}

jsonApiNormalize(input).get(['type']);
// returns { type:"article" }

To be:
Should return { type:"other type" }

Not sure how this should be resolved, because there might be situation where data.type is also needed. Maybe some special char should be introduced like $ eg $id would be equal to data.id and $type to data.type

Is there a way to preserve the received order of list data ?

Hiho,

thanks for your work!

Just wondering if it would be possible to offer a method that fetches all fields and relations by default?

Something like: normalize(articleJsonApiData).getAll();

Is there a reason why you only implemented get only via specific field names?

Cheers Florian

Hi,
The package does not keep of any errors that could be returned by the jsonapi endpoint.
I think the best way to handle this would be to keep the errors key in: meta.endpoint.url.errors at the same level the data would be.

Thanks