Integrate with retype the docs addition made by <a class="issue-link js-issue-link" da

<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-

Was reviewing <a class="issue-link js-issue-link" data-error-text="Failed to loa

The commit adds test for nav_js , not <code class="not

chrs - that leaves only <a class="issue-link js-issue-link" data-error-text="Failed to

<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="14

Docs additions about pagy HOT 7 CLOSED

ddnexus commented on June 25, 2024

Docs additions

from pagy.

Comments (7)

benkoshy commented on June 25, 2024

#404 is done and improved with: benkoshy@de415a5 on the retype branch.

The others to follow.

from pagy.

benkoshy commented on June 25, 2024

Was reviewing #411 - and the following commit 02013d426fdd56c366332fc450bd63197a86762c - my understanding is that countless cannot support javascript_combo navs?
What documentation changes should accompany this PR? (It wasn't altogether clear to me) - the following?

+     The `pagy_info` helper, which uses the total `count` is not supported.
-     The `pagy_info` and all the `*_combo_nav_js` helpers that use the total `count` are not supported.

And then a change log entry?

Pointer much appreciated.

Ben

from pagy.

ddnexus commented on June 25, 2024

The commit adds test for nav_js, not combo_nav_js as mentioned in the description (which indeed is not supported by countless).

I overlooked the description and focused only on the commit. We have to sort this out.

Maybe @hvanhonacker can clarify that.

from pagy.

ddnexus commented on June 25, 2024

OK, I got a minute and it looks like there's just a typo in the description of #411.

Now I remember looking at the #410 and reproducing the error... indeed this is a fix for *nav_js and the *combo_nav_js has nothing to do with it.