deantwo / hazeronadviser Goto Github PK

For some reason only the Cities table have the horizontal scroll bar.
But at the same time only the Cities table seem to have a fatter header.

http://hazeron.com/phpBB3/viewtopic.php?f=3&t=6867&p=78254#p78253

Simple typo in the coloring of a cell when there is overpopulation.

Making fix now.

Thanks to [Client Update: 7/02/2014, 7/03/2014](http://hazeron.com/phpBB3/viewtopic.php?f=3&t=6962 Forum thread) the number of reports for each city has been lowered insanely.
Rather than there always being around 18 reports, there is now only one or two.

This mean that the graphs is very empty now.

Suggestions:

• Change the graph (or chart) type to a "bar chart" or something. This would look better when there is very few reports.
• Merge the HSlice class into the HObj class. HSlice is no longer needed if there isn't a good number of reports to compare.

PS: [Name the graphs/charts better!](http://en.m.wikipedia.org/wiki/Chart Wikipedia:Chart)

Assign default values for all strings, would suggest "-" or so.
"-" wouldn't look to bad in a DataGridView I hope.

I had one of my cities report that they wanted a morale building, but HazeronAdviser didn't say a building was needed.

It turned out that the city had a 4 homeless people, which caused the morale to report a morale building demand. But since HazeronAdviser calculates amount of buildings needed based on home count and not citizen count.

If a mail file is corrupt or otherwise not as expected, the program crashes.

Images need to be added to the Resources.resx.

%USERPROFILE%\Shores of Hazeron\Mail

This line Main.cs#L36 doesn't work for Linux.

string[] fileList = Directory.GetFiles(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile) + @"\Shores of Hazeron\Mail"); // %USERPROFILE%\Shores of Hazeron\Mail

The AttentionCode for the cities table's "Home/Job" column isn't actived when there are too many unemployed.
Currently only warns about "job > homes".

Have to check if my ships are using another MessageType, or if it is only my ships.

The "Officer" table isn't cleared when scanning mails a second time.

It seems I am doing my calculations for needed extra Church levels is wrong.

Fix: Increase needed extra levels to 2 Church levels instead of 1.

Needs investigating.

The information on the wiki is not all that clear on what the population limit is for a planet that is between two size categories.
Anyone that know the answer to this?

http://www.hazeronwiki.com/Worlds#World_Population

When reading mails that have buildings that need repairs, the repairs replace homes in the city table.

Mail example with repairs:

LIVING CONDITIONS
Jobs 458
Non-Construction 457
Construction 0
Repair 1
Homes 460
Apartments 0
Condominiums 444
Farms 16
Houses 0
Orchards 0
Food 312855

The tooltip on the graph located on the Morale tab, is incorrect.

It seems to have been copied over from the Population tab's graph.

Simple fix. (When I get around to it)

Crashes if population section of a city report is the following:

POPULATION
Citizens are Omnivorous Glabrian.
Lack of a home prevented one person from immigrating.
Population remained steady at 0.

I need an icon for HazeronAdviser.
I was thinking something along the lines of a better quality version of the Hazeron icon with an "A" for "Adviser" or something at the bottom under Hazeron.

Anyone have any ideas? Or maybe even wanna make an icon?

Forum thread/post: http://hazeron.com/phpBB3/viewtopic.php?f=3&t=6867&p=82040#p82040

Can't read MSG_CityIntelligenceReport type messages.
This is because they don't look like normal city status reports.

Suggest to not read these mails as city status reports at all.

Loyalty on the pop-graph isn't super good at showing loyalty going from disloyal to loyal and vica versa,

Also may need to look into how it will show a loyalty level of plain zero.

If you have a "MSG_ShipLogFinal" type mail in your mail folder it will crash the program when trying to read it.

Need to add checks to see if a category is there before trying to SubString it out.

The cities in Shores of Hazeron has changes a lot. This includes city reports and their importance.
See: http://hazeron.com/wiki/index.php/Building_Update

HazeronAdviser need to be updated to work with new-style cities and bases.

_vMoraleModifiers isn't cleared when more mails are read from the same city.

Left over bug from merging HSlice into HCity.

Noticed this on one of Haxus's colonies that didn't have a church and HazeronAdviser didn't say anything about it!

This may also happen for Cantinas when there is less then 50 pop.

I am thinking it has something to do with HHelper.CleanText(string).

When a row is selected, it is impossible to see the warning colors on the row.

Solution: Set dgv.Rows[i].Cells["Column"].SelectionBackColor to another color as well when applying warning colors.

The graph for disloyal citizens is going DOWN rather than up.

Picture:

Need better icons, unsure if they should be the same as used in the Hazeron client or not and where to even get them.

Also may need icons with different states, like in the Hazeron client, one for each message type most likely.

While we are on the subject of icons, an icon for the program would be really good too if someone know how to make those.

A bug or something caused a few "War Declaration" mails to have an empty body. But for some reason the _body_l is 0xFF-FF-FF-FF rather than 0x00-00-00-00.

Bug report on the forum: http://hazeron.com/phpBB3/viewtopic.php?f=6&t=8856

I don't remember the specifics of this issue. It was posted on the old forum (here), but that was lost when the old forum died.

Need to investigate this again.

MSG_CityDistressReport, also known as cities that are in distress don't show up at all.

Since the city report rework last year, MSG_CityDistressReport mails are sent without the whole mail body.
Need to check if the mails only contain the DISTRESS section and ignore them if so.

The HMail class doesn't read the location data from the mails yet.
Should be easy to add.

See: http://goo.gl/E0yoYd

Right now the interval of the Y axle's points are horribly hard coded.
I have yet to find a good mathematical way to calculate it.

See this:

• https://github.com/Deantwo/HazeronAdviser/blob/master/HGraphics.cs#L134

If anyone can help me with this, I would be very thankful!

It might be useful to have the survey of a city's world.

This would however require the star map export XML to be imported into HazeronAdviser.
And there are some issues about the information in city reports. It might not contain reliable city location information.

After sorting the list by name or something else.
Selection doesn't show the correct mail in the textbox.

This is a problem when you for example scan your mails while you have research running.
And then scan your mails again after getting a new report where you don't have research running.

Ok. as an example research was a bad pick, because I fixed that, but for other things this is a problem.
A real solution is needed, instead of just resetting each var, because still will lead to problems when adding new vars.

It is currently not possible to see what empire owns the cities and ships.

Making it very confusing if you have two (or more) empires and don't remember the names of all your cities and ships.

Scanning mails multiple times adds duplicate information to the graphs.

See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at HazeronAdviser.HMail.IsUni4(Byte[] mailBytes)
   at HazeronAdviser.Main.btnScan_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.

Reported by Flint.
I am thinking it has to do with an empty mail file or some.

The Last Updated column displays the timestamp from when the mail was sent (requested) and not when the city's last report was created.

This will require me to decrypt the mail body's UTC:hhhhhhhh timestamp.

See: http://hazeron.com/phpBB3/viewtopic.php?f=3&t=6867&start=90#p78341
And: http://hazeron.com/phpBB3/viewtopic.php?f=3&t=6867&start=90#p78342

Bug added in last commit.

Need to remove ".SubString(11)", because it is removing the number I am trying to get!