deboorn / expbackoffworker Goto Github PK

It looks like this no longer works with Laravel 5.3 (and possibly other versions).

Declaration of ExpBackoffWorker\Worker::process($connection, Illuminate\Contracts\Queue\Job $job, $maxTries = 0, $delay = 0) should be compatible with Illuminate\Queue\Worker::process($connectionName, $job, Illuminate\Queue\WorkerOptions $options)

There is a change in the method signature as well as some of the internal implementation details.

Detailed description

We are having issues with Laravel Backup by Spatie due to rate limiting at Digital Ocean Spaces. We get time-outs / 503s. Besides options PHP Fly League S3 Driver (used by laravel Backup) gives us to do better error reporting there is no exponential backoff built in. We chatted with Flysystem https://github.com/thephpleague/flysystem-aws-s3-v3/issues/205 and Laravel Spatie spatie/laravel-backup#783 . Both agree exponential backoff is a good idea, but both packages do not provide this service.

So it would be great to either show in a test case how Laravel Backup could be used or an example in the README.md perhaps. This would help us a lot in our quest to get exponential backup to work.

Context

This change is vital to us to have Digital Ocean Spaces work for us for backups and potentially loading of static data. Currently backups only work partly and we had to give on on using their CDN for loading images of. Exponential Backoff would allows us to retry backups, cleanup of old backups after an x number of backups have been stored.

Possible implementation

Only idea of implementation I can think of currently is either an example of integration shown with a test or README.md example here or a new package that both uses Laravel Backup and Exponential Backoff. The former I think is better as both PHP Flysystem S3 nor Spatie Laravel Backup want to implement this directly as they want to focus on the core features of their respective packages.

Your environment

Include as many relevant details about the environment you experienced the bug in and how to reproduce it.

• Laravel 6.x, PHP 7.3
• Laravel Forge Ubuntu 18.04 on Digital Ocean Droplet
• Digital Ocean Spaces for the backup storage