declancm / maximize.nvim Goto Github PK

I updated my maximize today with lazy.nvim and deleted the `` and now have this config:

return {
  "declancm/maximize.nvim",
  config = function()
    require('maximize').setup()

    local keymap = vim.keymap
    local opts = { noremap = true, silent = true }

    opts.desc = "Toggle maximizer"
    keymap.set("n", "<leader>zz", "<Cmd>lua require('maximize').toggle()<CR>", opts)
  end
}

This is the error receive:

Failed to run `config` for maximize.nvim

vim/shared.lua:0: attempt to index a nil value

# stacktrace:
  - vim/shared.lua:0 _in_ **tbl_get**
  - /maximize.nvim/lua/maximize/config.lua:22 _in_ **setup**
  - /maximize.nvim/lua/maximize/init.lua:14 _in_ **setup**
  - lua/configs/plugins/maximize.lua:4 _in_ **config**
  - lua/configs/lazy.lua:8
  - init.lua:2

Because of the error maximize does not work anymore, whether through the Lua API or through the vim Command.

Special buffers like file tree buffers cannot be saved in the session so they are restored as empty buffers.

One solution to this problem can be to close these buffer like it's done in the neovim-session-manager plugin:

• https://github.com/Shatur/neovim-session-manager/blob/9652b392805dfd497877342e54c5a71be7907daf/lua/session_manager/utils.lua#L74-L79
• https://github.com/Shatur/neovim-session-manager/blob/9652b392805dfd497877342e54c5a71be7907daf/lua/session_manager/utils.lua#L129-L149

Currently the plugin doesn't work with nvim-dap-ui's elements (like the buffer of the watchers for example). It doesn't even restore them if you toggle maximize the source code buffer. I think it might be because nvim-dap-ui buffers are hidden or something, not sure what they're called; basically they're not visible in the list when you run the command :buffers

The quickfix buftype can be saved by adding localoptions to the sessionoptions but it still doesnt populate the window once the view is restored

two vertical split editing windows with Neo-tree window opened, if require('maximize').toggle() one of the editing window, then require('maximize').restore()(the same problem with require('maximize').toggle() again), the Neo-tree window will disappear, not a big problem, but wish better to fix.

When noice is set to route the messages this plugin doesn't work, error with invalid buffer id

System Information:
I'm on neovim 0.7.2.

How to reproduce and issue:
Open up a second buffer in a vertical split, so that we have two files, let's call them "buffer1" and "buffer2" in the left and right splits respectively. Then with focus on buffer1, run :lua require('maximize').toggle() three times (once to maximize,then minimize, then maximize again). On the third toggle, I get a message that says Already only one window and the split with buffer1 is closed and only buffer2 is visible. Subsequent toggle calls don't do anything.

hi there, thanks for your effort!

unfortunately it drops dirvish windows, either you toggle maximize in dirvish or in any other window.

is there a chance you can have a look at it? thank you!