delighted / delighted-node Goto Github PK

I'm not sure if this is the best place for this issue, but since I'm encountering it in the node project I'll start it here.

When trying to pass an emoji character in the delighted_email_subject property of the delighted.person.create call, I receive a DelightedError of:

{
  type: 'GeneralAPIError',
  message: '{"status":500,"error":"Internal Server Error"}'
}

Sample code:

const params = {
                email: '[email protected]',
                name: 'Jim User',
                properties: {
                    delighted_email_subject: '🚌 Jim, would you recommend us?'
                }
            }
delighted.person.create(params)

Simply removing the emoji character from the subject creates the record and sends the email with no issue.

I should also note that adding emoji's via the Delighted UI to the subject line works without any issue.

The docs currently suggest setting up a mapping like this:

var mapping = {
  '/people': {
    status: 201,
    body: { email: '[email protected]' }
  }
};

But the test server looks up mapping entries using the HTTP method plus the url path:

var mapped = mapping[request.method + " " + request.url];

The require path for the test server also appears to be wrong.

As suggested here https://delighted.com/docs/api/web

Is there a way to set the driver to "test"?

Is there an equivalent library for client side JS?

Would it be possible to create a way to the "properties" / tags of an existing users?

Hi, thank you for the library. Are you planning to add Typescript types?

fb116d8

Commit isn't being registered on NPM.

The promise created when making an API call to send a survey client.person.create(payload).then(...) has no catch(). If you send a payload which causes an API error (perhaps an invalid UTF8 char in the message payload), the API response never comes back... and the promise never resolves.

A catch() should be added to the API promise, and it should have a timeout.

DEFAULT_HEADERS is updated with API keys at instantiation, but is not cloned at that point.

If you have a single process doing backfills for several API keys simultaneously using separate clients, each time a new client is created its API key will start to be used by all existing clients.

> a = require('delighted')('foo')
> a.config.headers.Authorization
'Basic Zm9vOg=='
> b = require('delighted')('bar')
> b.config.headers.Authorization
'Basic YmFyOg=='
> a.config.headers.Authorization
'Basic YmFyOg=='
> a.config.headers.Authorization === b.config.headers.Authorization
true

Workaround is to ensure DEFAULT_HEADERS are never used:

> a = require('delighted')('foo', {headers: {'Accept': 'application/json', 'Content-Type': 'application/json'}})
> a.config.headers.Authorization
'Basic Zm9vOg=='
> b = require('delighted')('bar', {headers: {'Accept': 'application/json', 'Content-Type': 'application/json'}})
> b.config.headers.Authorization
'Basic YmFyOg=='
> a.config.headers.Authorization
'Basic Zm9vOg=='
> a.config.headers.Authorization === b.config.headers.Authorization
false

Running npm install delighted gives me an old version of the code.