Giter VIP home page Giter VIP logo

eldenring-api's Introduction

Hi there ๐Ÿ‘‹

I'm Deliton Junior, a full-stack web and app developer currently living in Portugal, and welcome to my Github Profile! I like to build cool stuff and solve real-world problems. I hope that someday, I'll be able to do something meaningful and help the world for the better. I'm also super excited about the upcoming human missions on Mars ๐Ÿš€

GIF

Quick facts

  • ๐Ÿ“– Currently learning DL, ML Ops, Go and Data Science algorithms
  • ๐ŸŒŸ Fields I like the most: WEB ๐Ÿ–ฅ, Mobile๐Ÿ“ฑ and Machine Learning ๐Ÿค–
  • โ›ณ I always excited to learn new things
  • ๐ŸŽฎ My first interaction with programming happened I was 10 years old, developing mods for my private Tibia server (Otserver)
  • ๐Ÿฆ– Strongly support the Open Source movement

Recent personal projects

Some tools I use

git React React Native C Javascript TypeScript html5 css3 GraphQL Apollo Docker Heroku Vercel Netlify Nodejs Express MongoDB PostgreSQL Golang java Python Django Pytorch

Find me on

Email Instagram Facebook LinkedIn Medium

Deliton's github stats

eldenring-api's People

Contributors

deliton avatar julesferreira avatar swifu69 avatar tonyfroc avatar willsoto avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

eldenring-api's Issues

Issue querying stats on Class

Getting this error: Expected Iterable, but did not find one for field \"Class.stats\"." The query thinks stats should return an array of ClassStats where the JSON is not set up as an array.

Inconsistency with Weapon Category

There are plural and non plural versions of categories, ie: Greatsword and Greatswords , Dagger and Daggers. This makes using the category argument tricky due to having to handle both category arguments for one category type.

Making an iOS app

Hello,

Thanks for this great API! Iโ€™ve sent you messages over Reddit but I have no ideas if you read those, so Iโ€™m making an issue here :)
Iโ€™m making an iOS app using your GQL API, you can see it here: https://github.com/Dimillian/The-Roundtable
Do you plan to add a search API? Would be wonderful. If youโ€™re not planing to do it I can look into it. Also some kind of filter / sort would be great. For example being able to request weapons by scaling rank or armor by weight.

Thanks for this great API!

Here is some screens:
Screenshot 2022-03-21 at 19 20 47
Screenshot 2022-03-21 at 21 34 25
Screenshot 2022-03-21 at 21 34 31

data.requires[{ inconsistent array}]

This is just looking at the "sorceries" request, but I wouldnt be shocked if it went further. So when looking at the array of "requires" it is too inconsistent to use as a source of sorting the overall fetch. we see that there are some which contain "intelligence" "faith" and "arcane" (ideal) while others will be missing some of the attributes or will have abbreviated the name (check out "Carian Slicer" requires [{"name": "Int", "amount": 14]) this is making it impossible to cater a list based on these nested arrays. Is there anyway to fix this across all fields (including weapons, incantations, ect?)

Thanks so much!

Upgraded weapon stats

Noticed that all weapon stats appear to be pre-upgrade. It would be useful to see at least max upgrade stats so that weapons can be compared at that point.

Thanks.

Add character creation options

Hello, I would like to know if there is any possibility of adding the properties and values โ€‹โ€‹for creating game characters?

something like this:

{
  "success": true,
  "count": 2,
  "data": [
    {
      "id": "000",
      "name": "Facial Balance", // Facial Structure Option
      "values": [
        {
          "name": "noseSize", // Facial Balance Option
          "slider": [0, 300] // min and max values available
        },
        {
          "name": "foreheadRatio",
          "slider": [0, 200]
        }
      ]
    }
  ]
}

Eccentric's Manchettes description is incorrect

Should be:

The knight Jerren's manchettes.

Jerren preferred a nomadic existence, but after spending time as a guest of the Carian royals, he became the guest commander for General Radahn. And for the first time, the restless tumbleweed would be bound by honorable oath.

Currently is:

Gauntlets of the Cleanrot Knights, celebrated for their undefeated campaign in the Shattering. The Cleanrot Knights vowed to fight alongside Malenia, despite the inevitable, if gradual, putrefaction of their flesh. Their acceptance of their fate made these battles fiercest of all.

Pagination

On my elden ring project I wanna add pagination. But how can I know what the last page is to check that my currentPage is not the lastPage?

Thanks alot, btw well done.

GraphQL CORS

Hi there. Great API and thanks for all the work putting this together!

I am trying to hit this API from the browser and getting a CORS pre-flight issue. Specifically:

405 Method Not Allowed

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://eldenring.fanapis.com/api/graphql. (Reason: CORS preflight response did not succeed). Status code: 405.

I do see in the Response Headers that you have access-control-allow-origin: * (which is correct if you intend to allow browsers to hit the API). But I also see there is an Allow header which is restricted to GET, POST. I believe this might be the problem.

Since you are using Next.js, I think we can just follow the example here to fix this.

I am happy to make a PR with these changes if you agree with the root cause and the suggestion solution. Please let me know. Thank you.

return total amount

Hey, super cool API! I just started playing around with it a bit and noticed that the API doesn't return the total amount of possible data, which makes pagination a bit tricky. Could you add a field like total next to count, so people don't have to "brute force" check if there is more data available than initially requested?

Rounded Values + nulls where 0s should be

Looking at some values from armor pieces, I could see all(?) values have been rounded down. E.g.: Black Dumpling
Your values = dmgNegation: 2 3 2 2 3 3 3 3; resistance: 24 15 null 20 null
Actual values = dmgNegation: 2.8, 3.1, 2.8, 2.8, 3.1, 3.4, 3.6, 3.1; resistance: 24 15 0 20 0

It would be awesome, if you could get more accurate numbers and maybe even replace the nulls with 0s.

Small error in Boss by ID documentation

image

The route for Boss By ID should be https://eldenring.fanapis.com/api/bosses/boss_id and not https://eldenring.fanapis.com/api/bosses/:boss_id there is a : in the route that results in an error if incorrectly copied / pasted.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.