deliveroo / determinator Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Approval

These branches will be created by Renovate only once you click their checkbox below.

• Update circleci/ruby Docker tag to v2.7
• Update actions/checkout action to v4
• Update circleci/ruby Docker tag to v3
• Update github/codeql-action action to v3
• 🔐 Create all pending approval PRs at once 🔐

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Currently this section says that you need to have such code in your initializer file

Determinator.configure(
  retrieval: Determinator::Retrieve::Dynaconf.new(host: 'localhost:2345'),
  feature_cache: Determinator::Cache::FetchWrapper.new(
    ActiveSupport::Cache::MemoryStore.new(expires_in: 1.minute)
  )
)

But, this class Determinator::Retrieve::Dynaconf does not require host parameter anymore, it requires these parameters base_url, service_name instead

When a feature has an override, the casting to hash seems to fail:

TypeError: wrong element type Hashie::Mash at 0 (expected array)
from /app/vendor/bundle/ruby/2.2.0/gems/determinator-0.3.0/lib/determinator/retrieve/routemaster.rb:53:in `to_h'

What

The part of code that checks overrides for determinations, seem to always look into the id -- while (the features bucket_type is guid) one would the keys on overrides to represent guids.

Solution

There is an easy solution of deciding to use id or guid here -- however backwards compatibility is a big issue here. Two ways I can imagine we get around this:

1. Do a major release and warn about the breaking change.
2. Check for both id and guid -- bit hacky but in reality these two never clash, so... we should be fine?

Thoughts?
/cc @jphastings