deltanet / adapt-contrib-narrative-audio Goto Github PK

View Code? Open in Web Editor NEW

This project forked from adaptlearning/adapt-contrib-narrative

1.0 1.0 0.0 562 KB

A component that displays an image gallery with accompanying text

License: GNU General Public License v3.0

JavaScript 57.67% Less 22.06% Handlebars 20.27%

adapt-contrib-narrative-audio's People

Contributors

Stargazers

Watchers

adapt-contrib-narrative-audio's Issues

If main audio extension is not enabled, an error is logged when trying to set reduced text

Mobile instruction doesn't show

Item instruction UI for the authoring tool would be better rather than the custom class 'item-instruction'

Having no component body text can cause layout issues when used with other plugins

If used with the icon-popup extension and no component body text is added the narrative item text layout is disturbed.

Caused by conflict in CSS with item body text and icon-popup both having float: right.

Adding the following CSS solves the issue:

.narrativeaudio__widget {
    clear: both;
}

Audio functionality needs updating inline with latest audio extension

Layout and arrows not correct RTL on iPhone

and

Content doesn't display correctly if audio is used. Only shows bug on Firefox browser.

Audio only plays on navigation arrow selection, not via progress icons or swipe

adapt-contrib-narrative-audio/js/NarrativeAudioView.js

Lines 332 to 348 in b75c1b4

 if (!Adapt.audio) return; 

 var currentItem = this.model.getActiveItem(); 

 if (this.isLargeMode()) { 

 if (this.model.has('_audio') && this.model.get('_audio')._isEnabled && Adapt.audio.audioClip[this.model.get('_audio')._channel].status == 1) { 

 Adapt.audio.audioClip[this.model.get('_audio')._channel].onscreenID = ""; 

 Adapt.trigger('audio:playAudio', currentItem.get('_audio').src, this.model.get('_id'), this.model.get('_audio')._channel); 

 } 

 } else { 

 if (this.model.get('_isMobileTextBelowImage')) { 

 if (this.model.has('_audio') && this.model.get('_audio')._isEnabled && Adapt.audio.audioClip[this.model.get('_audio')._channel].status == 1) { 

 Adapt.audio.audioClip[this.model.get('_audio')._channel].onscreenID = ""; 

 Adapt.trigger('audio:playAudio', currentItem.get('_audio').src, this.model.get('_id'), this.model.get('_audio')._channel); 

 } 

 } 

 }

File case is incorrect causing build failure on Linux

Command failed: grunt server-build:dev --outputdir=courses/582ddab766bb580b0757965b/6194e25f92dc645331292d44/build --theme=582de0cafff1fc521e078b87 --menu=adapt-contrib-deltaboxMenu
Error: Could not load /datadrive/www/test.adaptbuilder.com/temp/582ddab766bb580b0757965b/adapt_framework/src/components/adapt-contrib-narrative-audio/js/NarrativeAudioView (imported by src/components/adapt-contrib-narrative-audio/js/adapt-contrib-narrativeAudio.js): ENOENT: no such file or directory, open '/datadrive/www/test.adaptbuilder.com/temp/582ddab766bb580b0757965b/adapt_framework/src/components/adapt-contrib-narrative-audio/js/NarrativeAudioView'

adapt-contrib-narrative-audio.js has uppercase file name for view. File is lowercase.

Causes build error
Plugin v6.2.0
FW v5.17.6-D (Deltanet Fork).

Item bodytext is not accessible with the keyboard

If icon-popup is used the audio keeps playing the narrative item 1 audio instead of the icon-popup audio

Remove the functionality to play the current item audio as the audio plugin handls this now

Layout issue with the strapline when the button has a border

'_isResetOnRevisit' attribute missing from example JSON and schema

The '_isResetOnRevisit' feature is being checked in adapt-contrib-narrativeAudio.js but will not be available in the authoring tool.

Blank item title renders a space above the body text

Audio plays again when closing popup notify in mobile size.

On mobile size, closing the notify results in the audio from the notify playing again.

Add _globals to the templates

Using in authoring tool

Hi,

I installed the plugin and also the audio extension - no errors all good. I have added a narrative and also mp3s, but I cannot get any audio control.

What am I missing?

Thanks!
Kind regards,
Tim

Clicking the audio play button only plays the initial audio clip and not the item you are on

Audio should not be triggered if there is no src for the mp3

Add check for Audio extension before trying to play the clip

Missing properties from schema

Missing the following from items:
titleReduced
bodyReduced
_audio.src

	if (!Adapt.audio) return;

	var currentItem = this.model.getActiveItem();

	if (this.isLargeMode()) {
	if (this.model.has('_audio') && this.model.get('_audio')._isEnabled && Adapt.audio.audioClip[this.model.get('_audio')._channel].status == 1) {
	Adapt.audio.audioClip[this.model.get('_audio')._channel].onscreenID = "";
	Adapt.trigger('audio:playAudio', currentItem.get('_audio').src, this.model.get('_id'), this.model.get('_audio')._channel);
	}
	} else {
	if (this.model.get('_isMobileTextBelowImage')) {
	if (this.model.has('_audio') && this.model.get('_audio')._isEnabled && Adapt.audio.audioClip[this.model.get('_audio')._channel].status == 1) {
	Adapt.audio.audioClip[this.model.get('_audio')._channel].onscreenID = "";
	Adapt.trigger('audio:playAudio', currentItem.get('_audio').src, this.model.get('_id'), this.model.get('_audio')._channel);
	}
	}
	}

deltanet / adapt-contrib-narrative-audio Goto Github PK

adapt-contrib-narrative-audio's People

Contributors

Stargazers

Watchers

adapt-contrib-narrative-audio's Issues

Recommend Projects

Recommend Topics

Recommend Org