deltawhy / bukkit-fancyshop Goto Github PK

I should look at how Lockette/LWC handles this (if it does) - the obvious way might cause lag and preventing track placement won't work (carts can be pushed off rails).

This plugin is not compatible from version 1.12 onwards. Please update.

Name changing is upon is. Any plans to update this plugin?

For some reason the "no room" check for buying and selling only works every other time.

It should not happen.

Currently anyone can create a shop on any chest, and then access its inventory. This is obviously pretty bad.

Possible way to check permissions - use event priority MONITOR and check that no one else has cancelled the event. Need to test with Lockette, LWC, Grief Prevention, etc.

Don't know, is it on the newest version, but on version 0.4, it occurs. I can guess it's because of the fire - when I click item (ex. iron) with fire, on my cursor is iron (should be still fire).

As a shop owner, I want to sell 128 netherrack for 1 iron.

Oh, I found a big bug. Sort of. I use GriefPrevention so players can't open each others chests without permission, but if I do /fancyshop create on a chest I normally couldn't open then look in the shop's inventory I can steal everything a player has, then just remove the shop and they won't know who stole their goods. When you create a shop the player should be able to open the shop first before it is counted as a successful shop build, or better yet, you should add a sign method of making the shops. So if a player can build onto the chest it will count as a successfully created shop. But the sign could be later deleted for it to count as a successful shop. It's just upon first creation of a shop that would be the issue. Another way to make stealing players chests not possible would be to have a recently placed chest rule. So the player would have had to recently place a chest in order for shop creation to be possible.

As a poor shop owner, I want to sell an item for 5 diamonds but I only have 1.

Much easier than #3 since currency is restricted to simple items but the UI is still tricky.

As a shop owner, I want to be able to buy enchanted books and tools, wither heads, and other valuable items, even if I don't have one handy.

Not sure if this is in scope or would be better served by a different sort of plugin. Describing an item via text is difficult.

As a server admin, I want to prevent someone DoSing a shop by filling it with dirt.
As a shop owner, I want to use droppers to automatically restock my shop.

FancyShop v0.5 Total: 22.599 s Pct: 29.05%
FancyShop::onChunkUnload(ChunkUnloadEvent)
Pct Total Pct Tick Total Avg PerTick Count Event
28.89% 31.39% 22.47 s 15.70 ms 5.6 8.0k

Add a way to create unlimited (admin) shops.

This plugin provides an API for several "region" plugins: http://dev.bukkit.org/bukkit-plugins/flags/

I tried to sell a chain helmet that I had repaired to full durability. When adding the deal it seemed to be fine, but after reloading it shows as "out of stock" even though there is one in the chest. It seems Bukkit doesn't serialize the full data of the item.

There should be a way to turn off shop management for OPs.

For example this is what happens now:

Server OP creates an Admin Fancy Shop while in Creative Mode, but still wants to be able to buy/sell to while in Survival mode. (Just because you're OP doesn't mean you want to be unfair to your players). But when OP tries to access Admin Fancy Shop as a player, shop is still in the "Manage Shop" Mode.

Fix:
When in Survival Mode an OP defaults as a normal player, or since Admin Shops have unlimited resources the Access Shop Inventory button could be changed to a "Test Shop" or "Finalize Admin Shop" button. That way OP can still use Admin Fancy Shops like normal players using and Admin Shop.

As a server admin, I want to restrict shops to a certain set of currencies.
As a server admin, I want to allow some currencies with data values (such as lapis dust)