delvtech / elf-sdk Goto Github PK

Finish implementing the stubbed out getTokenPrice method

Originally posted by @jrhea in #37 (comment)

Create a helper method that only returns addresses of open terms

it might be better for this method to accept the tokenInfos need rather than passing the list and having it search.

export async function calcTotalValueLockedForTerm(
  trancheInfo: PrincipalTokenInfo,
  balancerVaultAddress: string,
  ptPoolInfo: PoolInfo,
  ytPoolInfo: PoolInfo,
  // etc etc
  assetProxyTokenInfo: AssetProxyTokenInfo,
  signerOrProvider: Signer | Provider
): Promise<Money> {

Originally posted by @jrhea in #37 (comment)

I found typescript error at this code line:
https://github.com/element-fi/elf-sdk/blob/1d85370eda22d4526799281ca4b5b291990d87a1/src/helpers/getReserves.ts#L56

it should be fixed like this
const decimals: number[] = [];

create a helper method to filter addresses by token symbol

• getTermByTokenSymbol (PR #14)
• getPoolByTokenSymbol

Goerli was slow to confirm txs without bumping the gas price for the swap example (PR #14). as a result, i added a quick hack to just pass a configurable gasPrice to the overrides. This should be optional and needs to be fixed properly.

It's easy to mess up PT spot price calcs for USDC bc it only has 6 decimals and totalSupply has 18.

The endpoint used for Yearn vaults is:

https://api.yearn.finance/v1/chains/1/vaults/all

It would be nice to have a method that accepts, for example, the token symbol (PT or YT) and returns the vault APY. Something like:

getVaultAPYByTokenSymbol(termAddresses, tokenSymbol)