dennislwy / yahoofinanceapi Goto Github PK

HI,

First of all great work and it help me a lot, but i think that i found an issue.
You are only assuming that the decimal symbol is '.' but it can be also ',' (European countries use this symbol)
So in the method ParsePriceAsync, inside Historical class, when you call Convert.ToDouble it will raise an exception. Before the cycle 'For' you need to add this line to don't have any problem with the decimal symbol
Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;

Hi Dennis,
Yesterday I tried your modified code for asynchronous operations.
First, the "csvData" is completely collected, but somehow the task "ParsePriceAsync" does not end. Am I doing something wrong? I can't get the final "List" with HistoryPrices. Im not so firm with asynchronous programming, can you please check that!?

Thank you very much.

I'm getting the following errors when trying to run the bat file. I've tried re-installing package using nugget but still no luck. In VS2017 the code seems fine and doesn't throw error.

YahooFinanceAPI\Utils\Json.cs(2,7): error CS0246: The type or namespace name 'Newtonsoft' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(3,7): error CS0246: The type or namespace name 'Newtonsoft' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(19,54): error CS0246: The type or namespace name 'JsonReader' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(24,54): error CS0246: The type or namespace name 'JToken' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(34,71): error CS0246: The type or namespace name 'Formatting' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(11,33): error CS0246: The type or namespace name 'JsonSerializerSettings' could not be found (are you missing a using directive or an assembly reference?)
YahooFinanceAPI\Utils\Json.cs(12,33): error CS0246: The type or namespace name 'JsonSerializer' could not be found (are you missing a using directive or an assembly reference?)```

Hi,

First of all, thanks for the work.
I'm currently using the project for a finance app of mine.

I'm facing an issue while using Mono : it loops without finding the cookie / crumb.
Work very well while using VS2017 CE.

Is it something you already came across ?

I tried using different versions of System.Net.Http, thinking that depending on the version, the web page could differ, but was not that...

Thks.

Hi there,

I got the following error:

FlurlHttpException: GET https://query1.finance.yahoo.com/v7/finance/quote?symbols=AAPL&fields=regularMarketOpen%2CregularMarketDayHigh%2CregularMarketDayLow%2CregularMarketPrice failed with status code 401 (Unauthorized).
Response body:
{"finance":{"result":null,"error":{"code":"Unauthorized","description":"Invalid Cookie"}}}

It seems it requires cookies.
Could you pls help me?
Regards
LUCA

Apparently, something has changed in the last couple of days. The error seems to suggest that some user authentication is missing. Any Idea?

Exception in thread "main" java.io.IOException: Server returned HTTP response code: 401 for URL: https://query1.finance.yahoo.com/v7/finance/download/GOOG?period1=1369346400&period2=1527112800&interval=1d&crumb=
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1889)
at sun.net.www.protocol.http.HttpURLConnection$10.run(HttpURLConnection.java:1884)
at java.security.AccessController.doPrivileged(Native Method)
at sun.net.www.protocol.http.HttpURLConnection.getChainedException(HttpURLConnection.java:1883)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1456)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1440)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:254)
at yahoofinance.histquotes2.HistQuotes2Request.getResult(HistQuotes2Request.java:132)
at yahoofinance.Stock.getHistory(Stock.java:327)

Hi

I'm new to C# and Microsoft visual studio, but I have downloaded your program and tried to run it directly, but get the error - A project with an Output Type of Class Library cannot be started directly. What am I doing wrong?

Best regards

Hi Dennis,
Thanks for your work.
The only correction is needed in description (README). As I have selectively checked, OHLC prices are not adjusted for dividends (but still adjusted for splits). The field AdjClose in now not adjusted for dividends as it was earlier.

At first, I would like to thank you for the code!
The code was working perfectly till yesterday, now the code in Historical.cs loops forever because the value in the if statement is HttpStatusCode.Unauthorized. The code gets a cookie value! Has Yahoo changed something in the api or is something in the code.

Looking forward to hearing from you. Thanking you in advance.

Panos Kourtesis

Hi

I've got your coding working or rather I just pushed the right button;) anyway, I'm trying to download historical prices on a weekly interval back 365 days for several tickers at the same time, but after a couple of tickers, it will return and the following error

Is there some kind of limit to how many times you can download? And would it be possible to work around this, by renewing the crumb? And how would you do this?

Best regards

Any idea how i can download intradays data?
I used
http://chartapi.finance.yahoo.com/instrument/1.1/[TICKER]/chartdata;type=quote;range=5d/csv
Now i tried with
https://query1.finance.yahoo.com/v7/finance/download/{0}?range=5d&interval=5m&crumb={1}
but not working as expected

Hi there,

This is a question more than a bug, I'm wondering how I would detect when yahoo data is pretty much returning the wrong data, 0 for multiple stocks.

I.e. I recently noticed that I requested 100 stocks and the stock price was 0 on yahoo's end, is there something in the api that tells me if the data being requested isn't right? or do I just have to loop through each stock and check if the value is 0?

Wouldn't it be better and more effective to replace this line

csvData = wc.DownloadString(url);

with this:

csvData = await wc.DownloadStringAsync(url);