deresute-tools / deresute-tools Goto Github PK

Existing bug. Will not fix unless there will be a big meta change where CC does not perform better than OL.
Reason: The current architecture makes it difficult to implement skills like OL and Encore.

So, I was messing around with the source code to see how it works and found something weird. Not really big bug though, since it is not common to use alt without other combo bonus with matching timer.

Steps to reproduce:

1. Add self.notes_data.to_csv("test.csv") on line 87 of src/simulator.py
2. Run the following lines

cards = [Card.from_query(i) for i in ["mio2", "karen4", "nagi2", "aiko4", "shin3", "sachiko2"]]
unit = Unit.from_list(cards)
live = Live()
live.set_music(music_name="M@GIC", difficulty=Difficulty.MASTER)
live.set_unit(unit)
sim = Simulator(live)
sim.simulate(perfect_play=True, support=113290)
exit()

3. See exported "test.csv"
4. On note 20-24, skill_2 (nagi2, alternate) activates without any other active skill that overrides the alternate -20% combo bonus, but bonuses_1 is still 0.
   On note 142, the same scenario happens but bonuses_1 is correctly -20

Is this the correct behavior? I don't have alternates in game so I can't check it.

https://www.reddit.com/r/StarlightStage/comments/fyqi7d/score_simulator_tool_v002/fn59081/?context=3

Too much effort to a feature only a few advanced users use. Will not fix. The responsibility falls onto the users to make sure the input is valid.

Minor Qt issue. Not sure how to fix.

Check #6 for reason.

As Title

Suggested Edits (for tool.exe):

- https://play.google.com/store/apps/details?id=jp.co.bandainamcoent.BNEI0242&hl=ja
+ https://play.google.com/store/apps/details?id=jp.co.bandainamcoent.BNEI0242&hl=ja&gl=US

- idx = content.find(u'現在のバージョン')
- app_ver = re.search('\\d\\.\\d\\.\\d', content[idx:idx + 200]).group(0).encode('ascii')
+ app_ver = re.search('\\["\\d+\\.\\d+\\.\\d+"', content).group(0)[2:-1].encode('ascii')