dereuromark / cakephp-mailchimp Goto Github PK

Anyone up for the job?

I think for Cake3 it would be cool if

• A more datasource type approach could be found so that you can also hook in validation etc.
• More tests, obviously

here is the correct link http://devblog.springest.com/mailchimp-datasource-for-cakephp/

Returning false in MailchimpAppModel::call() is problematic: the campaignCreate function returns an array with [..., 'status' => 'save', ...] when successful for example. So it succeeds, but because it has a status key, it still returns false although you then need the campaign id to send it. Maybe it should return $this->response anyway all the time as a last resort? I don't know enough how other functions normally react to decide on the best course of action.

In the MandrillTransport class its impossible to send a template that is stored on Mandrill without having a local template available. Which defeats the purpose of the Mandrill templates. The code on line 127 and line 85 also prevent you from passing template_content vars to Mandrill.

I'm not sure if this is by design or I'm totally confused on the usage of it.

v1.3 is deprecated, v2.0 is the current one.

what would be the advantages, what the disadvantages?

See https://github.com/dereuromark/cakephp-mailchimp/tree/dev for work in progress