Subscription list is invalidated if a parent unmounts a child. about react-atom HOT 10 CLOSED

Good find @nullberri. Could you give me a minimal example in codesandox.io that reproduces the issue? Happy to take a look.

from react-atom.

I wasn't able to reduce the complexity, without removing the error. So I am not sure what the underlying cause is. I was using react-window and have since just abandoned it for just pagination. Its not my ideal solution but virtualizating statefull components has been a pain. This seems to have resolved the undefined errors as well.

the original error I was getting was an error that changeHandlersByAtomId[atom["$$id"]][k] was undefined.

from react-atom.

@nullberri gotcha. Well I'll keep an eye out for that bug. If I find some time, I'll try to find a way to reproduce it.

Am I good to close this, or is there anything else I can do?

from react-atom.

Closing. Feel free to reopen if you find a way to reproduce the issue.

from react-atom.

@derrickbeining I figured it out.

Code to trigger the exception.
https://codesandbox.io/s/woo3z1n8kw

Should trigger 4x Uncaught TypeError: a[t.$$id][n] is not a function in the console.

from react-atom.

@nullberri thanks for a code sample! Unfortunately it's not reproducing on my end. Anything I should tinker with to trigger the issue?

from react-atom.

@derrickbeining Strange it happens 100% of the time for me, even across multiple computers. (Work laptop, and home PC)

Chrome Version 72.0.3626.109 (Official Build) (64-bit) on Windows 10 & windows 7.
And the error only shows up in the inspector not the codsandbox.io console.
I have included an image of the output I am seeing.
https://i.imgur.com/MmkV6RL.png

Edit:
Also happens in Firefox 65.0.1 (64-bit) on Windows 10, and
Chrome Version 72.0.3626.81 (Official Build) (64-bit) on Ubuntu

from react-atom.

@nullberri ah! Wasn't looking in the browser console. Okay, awesome. I'll try to find some time to look into how to prevent this.

from react-atom.

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from react-atom.

@nullberri , just tested the fix out on code sandbox and it appears to resolve the issue.

Thanks for bringing it to my attention and helping find the solution!

from react-atom.