Getting no TypeScript error in swap about react-atom HOT 3 CLOSED

@soeik my apologies for not seeing this sooner. No I don't think you're doing anything wrong. This is just the way TypeScript handles excess property checking. Here's a decent article on the subject. If you want to get a type error, you'd need to specifically annotate the return type of the update function in swap, like this:

export const setIsLoading = (isLoading: boolean) =>
    swap<AppState>(appState, (state): AppState => ({
        ...state,
        foo: 0, // now there's an error
        isLoading,
    }))

I'm sure there's a way I could improve the typings for swap to make it prevent excess properties more strictly. Don't have the time to mess with it right now, but if anyone wants to PR that feature, I wouldn't be opposed.

However, the excess property should be innocuous. The Atom's type will remain unchanged, so you won't be able to read any excess properties that get put in there. I guess theoretically, this does pose as a sort of memory leak if your app happens to continually add dynamically generated properties to the Atom, because they'd never be able to be garbage collected.

from react-atom.

Going to close this for now, feel free to comment further.

from react-atom.

Thank you so much for the explanation. Now I see what's happening. And I don't see any way to fix this, to be honest, unless TS introduces something like the exact type.

from react-atom.