Giter VIP home page Giter VIP logo

lunchbox's Introduction

Hi there, I am Devansh Aggarwal ๐Ÿ‘‹

  • ๐Ÿ“˜ I'm a software engineer based out of Bangalore (India)
  • ๐ŸŒฑ Iโ€™m here to learn new things and collaborate on interesting projects
  • โœจ I love travelling, bike rides, and photography
  • ๐Ÿ‘” Currently working as an Android Engineer at Fam
  • โš™๏ธ I have experiencing in developing Android applications, web applications using Django and have also tried my hands at Unity Game Engine

Connect with me:

avishreekh | LinkedIn devansh-299.github.io devansh-299.github.io



Devansh's Github Stats

lunchbox's People

Contributors

devansh-299 avatar epicadk avatar gowthamkrishna362 avatar maharishi-coder avatar unc0ded avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

lunchbox's Issues

Feature :Adding Models

Description

Add Cuisine models from here.
Remember to use the actual response ( the one you get when you use an apikey ) and not the sample response as they may differ.

Add Placeholder Image

Description

For a few restaurants, the images are not available. In such cases, we must have a placeholder image.
For Glide documentation, you can use this.

Screenshot

Create Layout

Description

Create Layout for home Fragment

Screenshot/Recording

Location Permissions

Description

Add Location Permissions Using Foreground service as required in android 10+.

Add Category Filters and Markers in Home Fragment

Description

Restaurants can be filtered on the basis of categories. In HomeFragment, users should be able to filter and distinguish restaurants catergory wise. For this, map markers and chips (to filter restaurants) can be used.

  • For map markers refer this page
  • For chips, we can use something like this
    Screenshot from 2020-10-06 23-43-21

Repository Singleton Pattern

Description

While following MVVM architecture, it's recommended to have the Repository as a Singleton, which is not followed in this app yet (a new instance is created for every ViewModel instance, and in one of the ViewModels, even for every method in the ViewModel).
Edit: Since ApiService is already a singleton, this is now only a code style issue. Only a global Repository instance should exist in every Viewmodel.

Unwanted back button in toolbar

Description

  • SearchFragment and FoodFragment show a back button in the toolbar, which is not desired, as they are top-level destinations.

Screenshot/Recording

Misc UI fixes

Description

  1. Splash screen status bar color does not match the general app status bar color.
  2. White status bar color makes the status bar icons illegible (Red is better, or maybe red with a little less alpha).
  3. Expanded app bar text color in RestaurantDetails is a darker color, white would perhaps be more legible.
  4. 'Clear Filter' chip fontFamily has not been changed.

Screenshot/Recording

1. 2. 3. 4.

Update Readme

Description

Update Readme with the libraries we use.

Add Subscriber and Observer in Repository

Description

Currently in the repository we are returning only Single however we can also return a single with the subscriber and observer already added to it (subscribeOn and observeOn method already invoked) so as to reduce repetition of code.

Add Restaurant Details Screen

Description

Currently, we have the recyclerview to display restaurants but nothing happens when clicking on a restaurant item. The idea is to direct users to that specific restaurant's details when clicking on the item.

  • API Documentation: link
  • Also, please describe your approach (design) before sending a pull request

Create Requests

Description

Create API interface containing requests to the API

Screenshot/Recording

No screenshot

Feature : Set Iconified by default to false

Description

Currently in the Search fragment the Search View is brought into focus only when we tap on the icon.

If we add iconifiedbydefault and set it to false in the Layout file then no matter where the user clicks the search view will be brought to focus

Add Models

Description

Add Category model from here.
Remember to use the actual response ( the one you get when you use an apikey ) and not the sample response as they may differ.

Add Retrofit

Description

Create a singleton class returning containing retrofit instance

Screenshot/Recording

No Screenshot

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.