devunt / make-gis-great-again Goto Github PK

Hi.

Script does not working with Tampermonkey.

Guys
Chrome has extension that has BOTH "View Image" and "Search by Image"...
https://chrome.google.com/webstore/detail/view-image/jpcmhcelnjdmblfmjabdeclccemkghjk

Aaannnd so is FireFox now...
https://addons.mozilla.org/en-US/firefox/addon/view-image/

This plug-in actually makes image search better. By naming it "Making GIS Great Again", you imply that it will slowly but surely destroy everything about image search that we love and reduce it to a burning pile of rubble. Please update this plugin accordingly.

I'm using Version 64.0.3282.167 (64-bit)

I've restarted chrome after installing, but I still see no changes to GIS -- there is no View Image button added. I don't see anything in the page console to indicate an error.

Happy to provide additional details, but don't know where to look.

Doesn't works on site google.by but works on google.ru. I cannot check on google.com, it redirects me to google.by.

Hello,
Thank you for this great script.

Can you add multilanguage buttons?
English = "View image"
German = "Bild anzeigen"
...

Greetings 👍

Seems like Google have changed something as the extension isn't working for me anymore.

As of February 28, 2018, chrome extension stopped working.

• Doesn't work with userscript (Tampermonkey, Chrome 69, Windows 10) on any Google images result. I just don't see a button
• Been like this for a while now
• Works when I use the extension

Console from userscript:

Hey, I noticed the button doesn't show up when going into sites like this one. Also, when changing from one preview to another (i.e. when choosing a related image) and clicking the button it just shows the original image you clicked, not the related image. Thanks for the extension by the way!

Google broke the image search again. It looks completely different now and the "View Image"-button is gone.

Bug description:
I'm running Firefox 61.0.1 (64 bit) on Linux Mint 18.3 (64 bit).
Your add-on works perfectly as long as I left-click on an image in the Google Image search results:
https://www.google.com/search?q=kittens&source=lnms&tbm=isch&sa=X
But when I do one of the following:
a) right-click + select "open in new tab"
b) shift + left-click
c) ctrl-shift + left-click
then the "view image" button is missing.
It's no big deal if you know about it, but if you don't, it can make you think that the add-on doesn't work at all.

• Are you using browser extension or userscript?
  browser extension

• Is "Make GIS great again" working on other pages?
  sorry, i don't understand the question :-)
  the add-on is for google image search only, so what "other pages"?

• Is error disappeared when you changed extension/userscript to userscript/extension?
  no, the error is the same with the userscript version

• Link to page where error occurs
  https://www.google.com/search?q=kittens&source=lnms&tbm=isch&sa=X

• Screenshot of page where error occurs
  left-click (works) = https://imgur.com/tNFiG75
  right-click (doesn't work) = https://imgur.com/V4bJ7Xq

• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)
  are you kidding me?
  how many more hoops do i have to jump through before i can finally submit this bug report?

Any reason why the Firefox wouldn't show in extensions/add-ons/plugins after installation? Firefox says it was successfully installed but even after restarting the browser I am having trouble locating it. For example Add-ons shows nothing installed as well extensions, and plugins just has usual OpenH264 Video Codec and Widevine Content Decryption module.

• Are you using browser extension or userscript?
  Chrome extension
• Is "Make GIS great again" working on other pages?
  NO SETTINGS
• Is error disappeared when you changed extension/userscript to userscript/extension?
  No
• Link to page where error occurs
  https://www.google.co.jp/search?q=test&source=lnms&tbm=isch&sa=X
• Screenshot of page where error occurs
  https://i.imgur.com/lKU5Lo8.png
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)
  https://i.imgur.com/5u6TjjI.png

BTW, Works fine on "google.com".("画像を表示" mesns "View image" in Japanese.)
https://i.imgur.com/z50GtUH.png

This was working, but it looks like Google have changed their page causing the script to fail when trying to add the button.

Example link:
https://www.google.co.uk/search?q=sega+power+strip&num=40&tbm=isch

Output from console:

Uncaught TypeError: Cannot set property 'innerText' of null
    at addButton (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:51)
    at addedNodes.forEach (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:81)
    at NodeList.forEach (<anonymous>)
    at mutations.forEach (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:80)
    at Array.forEach (<anonymous>)
    at MutationObserver (userscript.html?id=cd697653-4be5-43f7-b18b-1d1540ce687a:77)

• Are you using browser extension or userscript?
  extension
• Is "Make GIS great again" working on other pages?
  dunno
• Is error disappeared when you changed extension/userscript to userscript/extension?
  haven't tried
• Link to page where error occurs
  https://www.google.com/search?q=seteais+palace&num=100&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjf3prU993aAhVEuxQKHUgZDMsQ_AUICigB&biw=2844&bih=1526#imgrc=Rfj-87Pu1QPc5M:
• Screenshot of page where error occurs
  n/a
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)
  

The button does not appear. Exact error from Developer Tools is attached.

[edit added 2020/01/22]
To install the lastest version of the script, check the current version number in this repository, below in this thread, and in my fork.
Use the method in this comment to install/update the userscript. When installed that way, it will be updated automatically every time the source is updated.

[Original message]
For some time now I have been using your script as a userscript in tampermonkey.
I had it modified in two places:

• It gets the language info from the page itself, not anymore from the browser (only as a last resort). It prevents a mixture of languages (my chrome is in english, but the page is in FR or EN).
• I add a link "Search by image" at the top of the text block (like in another extension IIRC)
• I have also added other languages. But not always for both the button and the link. I don't recall the exact source of this. Maybe requests here or on the webstore page.

At the time, I was planning to PR the new code here, but I got focused on other projects.

I did not notice immediately the effect of the new CSS ; in incognito mode the old style is still in use, and the script still works.
The code below can handle the old and the new style.

I can PR it if you want. And post explanation on the modications.

// @version         1.5.0.2

use latest version below

Can anyone else confirm if this add-on works with Firefox ESR on their computer? It installs but appears to do nothing.

The extension fails to load the View button on the "full screen" GIS view that is sometimes used when clicking an image from the main Google results page. I discovered this problem by clicking on the first image on the "knowledge panel" to the right of the search results. If there are multiple images in the panel, only the first one opens to this full screen view; the other images will redirect to the normal GIS results page of the subject.

• I am using the Google Chrome extension version of MGGA.
• MGGA works properly on the usual GIS result page.
• I am currently unable to test the userscript version, so I can't confirm if this problem exists on it as well.
• Link to where problem occurs: here.
• Screenshots:
  
• The knowledge panel, just to illustrate what I'm talking about.
  
• The full screen image result page with button not loaded.
  
• Dev console.

I use this version because I don't like what google made of chrome in the latest versions.

Usually all extensions works fine for me in my old chromium but your extension is not working at all.

Using the Firefox extension, the 'view image' button no longer displays as of today. Until yesterday it was working fine.

An opportunity to make GIS greater than it ever was: rather than just opening the image as if when clicking the old "View image" button on Google (with inages.google.com as the HTTP referer), actually take the URL of the "Visit page" button, and inject that as the Referer header when the user clicks "View image".

Even better, use the "Visit page" links as referers when loading the images embedded in the search listing. This effectively defeats schemes where the image is blocked or blurred when coming from Google.

Makes Stupid Cunts Think They're Clever Again

Nice implementation though. Appropriate that an american company gets taken down by a stock image host, and the workaround is named after a stock company that took america down.

• Are you using browser extension or userscript?
• Is "Make GIS great again" working on other pages?
• Is error disappeared when you changed extension/userscript to userscript/extension?
• Link to page where error occurs
• Screenshot of page where error occurs
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)

MGGA is not showing up at all anymore, on any pages.

• I'm currently unable to test the userscript version; if anyone knows its status please chime in.
• Link to page where error occurs
  
  

I'm assuming just a GCode change, but thought I'd let you know before the review rating gets tarnished on Mozilla Add-Ons.

• Are you using browser extension or userscript?
  Extension
• Is "Make GIS great again" working on other pages?
  No
• Is error disappeared when you changed extension/userscript to userscript/extension?
  No
• Link to page where error occurs
  images.google.com
• Screenshot of page where error occurs
  https://prnt.sc/isqk29
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)
  https://prnt.sc/isqk6s

-double fr translate entry
-you can add turkish -> tr: 'Resmi Görüntüle',

Example

-remove- Sorry, I may have done something wrong.

A few days ago Google updated UI and now view image extension is not working on Google Chrome

https://addons.mozilla.org/en-US/firefox/addon/google-search-view-image/

Did Mozilla take this down? If so, can you provide an alternative download?

Any chance of providing an XUL/XPCOM version, for Firefox legacy browsers, like 'Firefox ESR', 'Pale Moon' and 'SeaMonkey'?

Example Google search URL: Click
Example Image URL: Click

When clicking an image from Google Search under Pages that include matching images the button is not added. Would be awesome if you could implement it there as well.

Hey

You can still improve it so that after clicking on the thumbnail you can open the picture from the times it was before?

Alternatively, add a button to show the image on this sub-page after clicking the thumbnail.

I mean THIS and THIS.

Thanks

When you click on a related image on google, and then click the "view image" button, the original image that you clicked on in the google search appears, not the one that you switched to (the related one.)

When I click a related image the view-image button doesn't update the new image url,
I've read the source code, I know how it works, I tried to fix it but, I didn't find the new related image JSON data.

• Are you using browser extension or userscript? Userscript
• Is "Make GIS great again" working on other pages? Yes, checked on .co.uk and .in domains.
• Is error disappeared when you changed extension/userscript to userscript/extension? Extension works fine. Its a bug on userscript.

Before the recent changes, clicking the listed resolution of an images would result in a search for alternate sources of the image, listed by resolution.
It's still possible to get these results by copying the image URL, going to images.google.com choosing search by image, picking URL and pasting in the source you found.
With this (first result for an image search for "car") as an example URL: https://www.cstatic-images.com/stock/379x253/15/img-1276321340-1509471668915.jpg

This would be the search URL showing alternate sizes (Which doesn't look very helpful to me):
https://www.google.com/search?safe=off&hl=en&q=car&tbm=isch&tbs=simg:CAQSlwEJVyVSPBXpYsYaiwELEKjU2AQaBAgVCAgMCxCwjKcIGmIKYAgDEijzDfYN8g30Dd0E9Q3OBPEN-Q3fBMoyvTLhILwyyzLJMroywzK1P84yGjDoZ8pA9mX7Mcv7BXxuBq7OhozZf739GJrh9kmrbxrUZQ39zo7EXosNGWkgra33MnMgBAwLEI6u_1ggaCgoICAESBAUYHhsM&sa=X&ved=0ahUKEwiarKHB6KzZAhUD0WMKHfNcAmUQ2A4IJygB&biw=1920&bih=974

I'm running the latest Make GIS Great Again extension in Firefox 59.0.2 on Mac 10.13.4.

I cannot get the View Image button to load at all during Google Image searches. I see reviews for the plugin mention the same issue, but I didn't know if you watched those as much as GitHub issues.

Here's a video of what I'm seeing. https://www.screencast.com/t/Q3RVmh8YvX

Thanks!

• Are you using browser extension or userscript?
  Browser Extension

• Is "Make GIS great again" working on other pages?
  No

• Is error disappeared when you changed extension/userscript to userscript/extension?
  No

• Link to page where error occurs
  All images

• Screenshot of page where error occurs
  All images

• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)
  https://i.imgur.com/4vPYD3h.png

Are you fucking serious ?
https://i.imgur.com/PkLZcMP.png

I'm on opera 51, win 7 using Install Chrome Extensions and this stops videos from autoplaying on youtube. Don't know if I call it a bug or a feature.

https://github.com/bijij/ViewImage
This developer's browser extensions for Firefox and Chrome can bring back both buttons. But I really really want to keep using Safari on Mac. Can you update the Userscripts to restore both "View Image" and "Search by image" buttons?
Thank you very much!

Neither the extension nor the Userscript work (anymore?). Did Google Images change the layout of their result page?

@devunt Google changed something again. It still gets the images just the layout is all messed up

• Are you using browser extension or userscript?
  Browser extension
• Link to page where error occurs
  All Google images when you click on them
• Screenshot of page where error occurs
  https://i.imgur.com/f5wA2uI.jpg

• Are you using browser extension or userscript? browser extension
• Is "Make GIS great again" working on other pages? yes
• Is error disappeared when you changed extension/userscript to userscript/extension?
• Link to page where error occurs
• Screenshot of page where error occurs
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)

hello,

i have a problem with french translation who doesnt work :
i must change default language in this line :
const localizedViewImage = lang[(lang[navigator.language] ? navigator.language : 'en')];
by
const localizedViewImage = lang[(lang[navigator.language] ? navigator.language : 'fr')];

i think the detection doesnt work.

Ty for your work

description This userscript adds "View Image" button to Google Image Search results.

description:tr Bu komut dosyası, Google Görseller arama sonuçlarına "Resmi Görüntüle" düğmesini ekler.

Please add this description.

Another problem
Would you please write G with capital letter?

tr: 'Resmi görüntüle', --- tr: 'Resmi Görüntüle',

Hi,
Google removes "view image" button but "size" button too. Is it possible to add the "All sizes" button too?

Thank you.

Does not work on encrypted.google.com.

• Are you using browser extension or userscript?
• Is "Make GIS great again" working on other pages?
• Is error disappeared when you changed extension/userscript to userscript/extension?
• Link to page where error occurs
• Screenshot of page where error occurs
• Screenshot of Developer tools' "Console" (Firefox — Control+Shift+K, Chrome — Ctrl+Shift+J)

-I tried both the extension and the script.
-It does not work on ANY Google Image Search result.
-Error persists regardless of which version I use.
-Link to example page:
https://www.google.com/search?sa=G&hl=en&q=gorillaz+gorillaz+album+cover&tbm=isch&tbs=simg:CAQSlwEJaBjozYfv8WkaiwELEKjU2AQaBAgVCAQMCxCwjKcIGmIKYAgDEijAEvoDnAKwAvwDyAatCp4CuxLHBtcmiTOqIdIm6TyBM4AzijPqPK4mGjA5uLIX5mrpnkqI5SjuAzhRKLr-8aex8d057_1Qf_1RObcqH4zvoezDfQg_1BeyOs9PmUgBAwLEI6u_1ggaCgoICAESBHCwrW8M&ved=0ahUKEwjj1Nrd0ejaAhUH0lMKHR-ICtUQ2A4IJygB&biw=1920&bih=900#imgrc=arvpscqacf05bM:
-Screenshots attached.