Giter VIP home page Giter VIP logo

Comments (3)

vutran avatar vutran commented on May 23, 2024

This makes sense.

jest's mock system is a bit weird. If I remember correctly, the root __mocks__ directory usually store mocks for node_modules. For local modules, a __mocks__ directory should be located alongside the file it is trying to mock.

Example:

- src
  - utils
    - __mocks__
      - foo.js
    - foo.js
    - foo.spec.js

from dext.

adnasa avatar adnasa commented on May 23, 2024

For local modules, a mocks directory should be located alongside the file it is trying to mock.

yeah absolutely, this makes sense of course, but we're going to have to decide as we do the migration.

Imagine the following on a larger scale

src
  a
    a.spec.js
    a.js
  b
    b.spec.js
    b.js
another-folder
  c
    c.spec.js
    c.js

Given a and b requiring c, with your suggestion, where do we mock c? 😄
root folder of src? I'm asking because I don't have any extensive experience of putting mocks inside a __mocks__ folder. only inline-mocking (with jest even). Maybe the example above works 😄

from dext.

adnasa avatar adnasa commented on May 23, 2024

I will close this now, since I'm pretty happy that we moved all the .spec.js files.
As for missing tests on components and other utilities, let's pick this up later.

Thanks for all the reviews!
😉

from dext.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.