Comments (3)
This makes sense.
jest
's mock system is a bit weird. If I remember correctly, the root __mocks__
directory usually store mocks for node_modules
. For local modules, a __mocks__
directory should be located alongside the file it is trying to mock.
Example:
- src
- utils
- __mocks__
- foo.js
- foo.js
- foo.spec.js
from dext.
For local modules, a mocks directory should be located alongside the file it is trying to mock.
yeah absolutely, this makes sense of course, but we're going to have to decide as we do the migration.
Imagine the following on a larger scale
src
a
a.spec.js
a.js
b
b.spec.js
b.js
another-folder
c
c.spec.js
c.js
Given a
and b
requiring c
, with your suggestion, where do we mock c
? 😄
root folder of src
? I'm asking because I don't have any extensive experience of putting mocks inside a __mocks__
folder. only inline-mocking (with jest even). Maybe the example above works 😄
from dext.
I will close this now, since I'm pretty happy that we moved all the .spec.js
files.
As for missing tests on components and other utilities, let's pick this up later.
Thanks for all the reviews!
😉
from dext.
Related Issues (20)
- App search HOT 2
- [Question] execute command immediately after entered keyword (no need to specify query) HOT 4
- Hide from the dock and add context menu HOT 2
- getting disabled plugins HOT 4
- Plugins should fallback to icon.png for items
- Linux packaging error
- yarn run build:prod error HOT 1
- settings window HOT 3
- Core plugin calculator returns functions upon specific queries HOT 1
- Does the Alfred theme to Dext theme conversion tool have a place in dpm-cli or should it be it's own tool? HOT 3
- How Can I start up dext app when I login to Mac HOT 2
- consider automating dep updates HOT 1
- upgrade build
- have redux-saga removed HOT 7
- add test for `utils/CacheConf`
- add test for `utils/conf` HOT 5
- RFC: remove `app/renderer/src/schema` HOT 2
- upgrade react
- remove destruct HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dext.