have redux-saga removed about dext HOT 7 CLOSED

We decided to move forward with removing Redux for the new Context API. Let's try to get React updated to the latest version so we can get this new hotness ready for the migration.

from dext.

Let's try to get React updated to the latest version

I'm on it 😄

from dext.

One cool thing about using context here would be to eliminate imports of ipcRenderer,
which essentially means that we leak electron functionality into our components.

Admittedly, I have yet to try out the new Context API, but even with the old approach, you could see the benefit

class A extends React.Component {
  getChildContext () {
    return {
      socket: ipcRenderer,
    }
  }
}

class B extends React.Component {
  static contextTypes = {
    // because `context`, `socket` doesn't have to interface `ipcRenderer`
    socket: PropTypes.shape({
      on: PropTypes.function.isRequired,
    })
  }
}

// unit-test
// mock all the things..
const view = shallow(
  <B {...props} />,
  {
    socket: {
      on: jest.fn()
    }
  }
)

from dext.

Can I start working on this? Anything essential I need to know before working on this?

from dext.

Can I start working on this? Anything essential I need to know before working on this?

@himanshuchauhan Definitely. Let's try to keep the PR small since it's a huge migration. Ideally, we can move one state at a time. Please refer to PR #206 for an example of what we previously did. Let us know if you have any other questions.

Thanks!

from dext.

Let's try to get React updated to the latest version

#211 🔥

from dext.

🚀

from dext.