dfridrich / ares Goto Github PK

Wrong configuration prevents running phpunit tests. More importantly, the tests act like they were successful, but that is just because no tests were really executed.

For example see https://travis-ci.org/dfridrich/Ares/jobs/510557015

V nette vyhazuje metoda findById z třídy Justice chybu, že IČO není integer, ale jako integer vkládané je.

$ares = new \Defr\Ares(); $record = $ares->findByIdentificationNumber(27755941); $people = $record->getCompanyPeople();

Navrhuji drobné doplnění

public function findById(int $id)

Projde to pak Assertion:integer testem

V metodě extractDetailUrlFromCrawler stejné třídy navrhuji změnu $href[1] na $href[0], protože jinak to vrací úplné výsledky, ale samozřejmě neaktuální.

getTaxId()

Defr\Ares\Tests\AresTest::testFindByIdentificationNumber 
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'CZ8508095453'
+''

getPeople()

2) Defr\Tests\JusticeTest::testFindById
Failed asserting that actual size 0 matches expected size 2.

A new ARES is accessable at location https://ares.gov.cz/, it provides REST API, so no longer will be need the XML communications. It also has a documentation https://ares.gov.cz/swagger-ui/. Currently is the new ARES in a pilot mode and according to the words from Czech ministry of finance it contains data until 30th of July 2023. But the old ARES will be running concurently with the new one until 30th of September 2023. And then the old one will gone.

Hi guys! Is there any reason why is AresRecord mutable?

https://github.com/dfridrich/Ares/blob/master/src/Ares/AresRecord.php

Thanks!

Bylo by prosím možné změnit URL na https?

https://github.com/dfridrich/Ares/blob/master/src/Ares.php#L18

AresExceptions should return proper error codes.

Defr\Ares contains http addresses, I think it would be better to use https there.

If I search empty string, you converted into int (which is 0 and ICO returned from ares is 0.. so you have valid IC number).

Hi and thanks for this library.

When searching by company name, there is a bug that issues count(): Parameter must be an array or an object that implements Countable warning when no companies are found (in other words: empty XML is returned).

This is due to following line of code, that cannot handle the case when $elements variable is null since null is not Countable:

if (!count($elements)) {
      throw new AresException('Nic nebylo nalezeno.');
}

Today i found a problem. If I have a leading zero with my company id (ICO). The result of findByIdentificationNumber is int.. so the leading zero disappear and I have invalid company id.