Giter VIP home page Giter VIP logo

nempay's Introduction

NEMPay

NEMPay is a mobile app to transfer NEM mosaics easily.

Distributed as an open source solution, it can be customized to create apps that transfer assets such as tickets, coupons, stocks or even share representation, cutting costs of acquisition.

NEMPay has been developed in Ionic, and currently available for Android and iOS.

Provided Features

alt text

  • Create/Import Account
  • View balance
  • Send xem / assets
  • Create bills
  • Address book
  • Scan QR
  • View transactions
  • Share Address

Getting Started

  • Clone this repository: git clone https://github.com/dgarcia360/NEMPay.
  • Install ionic (npm install -g ionic)
  • Install cordova (npm install -g cordova)
  • Run npm install from the project root.
  • Run ionic serve in a terminal from the project root.

How To Contribute

See CONTRIBUTING.md and CODE_OF_CONDUCT.md ๐ŸŽ‰๐Ÿ‘

Collaborators

Username Role
dgarcia360 Project lead
guillemsole NEM Library Integration
mizunashi Quality assurance & Japanese Translation
acastellana Quality assurance
jabo38 Quality assurance
AnthonyLaw Chinese Translation
cyrus1683 German Translation
shenrgc Spanish & Catalan Translation
tongokongo Polish Translation
seonhyeseonhye Korean Translation
yarkitest Russian Translation
Jordi Logo Designer

Telegram Group: https://t.me/nemprojects

License

MIT License

nempay's People

Contributors

anthonylaw avatar dgarcia360 avatar guillemsole avatar mizunashi avatar shenrgc avatar tongokongo avatar yarkiytest avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

nempay's Issues

Transactions page didint show all the transactions instead of showing 10 transaction only.

Hi dgarcia,

May i know the reasons why the transaction page can show 10 transactions only? Does this need to be fix where we should show all the transactions as it stated in the function this.nem.getAllTransactionsFromAnAccount(this.selectedWallet.address).

I think we have another functions accountHttp.allTransactionsPaginated(address). Should we use this instead?

Thank you.

Could not sign up with private key from nempay wallet itself

Hi dgarcia,

I can sign up the wallet with private key if i scan the qrcode from the nanowallet account page after i enter my password. But I could not sign up the wallet with private key if i scan the qrcode from another nempay account page after i enter my password. It will throws an invalid password. This is failed as i know the nempay account qr code doesn't contain the private key. So what is the actual logic that need to implement at Sign Up with private key page

Thank you very much for previos fixed.

Cannot import wallet with password shorter than 8 characters

Minimum number of characters in NEMPay is larger than in NanoWallet. I have a wallet with 6 digit password that I want to import. I scan the QR code, input the correct 6 digit password but I get an error message that the password is incorrect.

Delete wallet

The login page should have the possibility to delete unused wallets. When trying to remove a wallet, it should appear a modal warning about the chance of losing the private key if not stored somewhere else.

As a user, I want to be able to send non-transferable mosaics to the creator

Expected Behaviour
When trying to transfer a non-transferable mosaic, it should allow to send it only if the recipient it is his creator.

Current Behaviour
Right now it appears an alert spotting that the mosaic it is not transferable.

Steps to reproduce
Go to Balance.
Select a non-transferable mosaic.
Click transfer button.

Retrieve wrong wallet when login

Hi,

First, I login with 1st wallet and then quit the nempay app. Then I login again with 2nd wallet. The wallet name display at below is refer to 1st wallet.

<span [innerHTML]="walletName" style="padding-left: 10px">

Thanks.

Confirmation about self node selection

Expected Behavior
Node selection must be connected to a working super node.
And the delay of hight needs to be within the allowable range.

Current Behavior
Since it is a self-node selection, you can not select a node manually.

I will tell you about problems that are currently occurring in NanoWallet.
When san.nem.ninha is set with NanoWallet, Green Circle appears and appears to be functioning normally.
However, currently, san.nem.ninja does not have chains synchronized.
In response to such a problem, I'd like you to check whether automatic node selection works correctly.

Steps to reproduce
none

Reference link:
https://forum.nem.io/t/please-do-maintenance-or-stop-san-nem-ninja/8345

QR code does not support mosaic

Expected Behavior
When the QR code is read, the mosaic set on the receive screen is reflected on the send screen.
(In the following captures, I expect "puthikun:thx" to be reflected as a mosaic of send screen.)

Current Behavior
Even if any mosaic is selected, it always becomes xem on the transmission screen.

Step to reproduce

  1. select some mosaic and make a transition to the receive screen.
  2. Launch the NEMPay app on another smart phone and read the QR code on receive screen.

Other
Like the QRCode contents it seems that the QR code does not correspond to the transmission of the mosaic.

QR code corresponding to transmission of mosaic is discussed in Japanese community.
In Japan, there is a growing demand for mobile wallets corresponding to mosaics.
so I want you to specify the standard of the QR code corresponding to the mosaic.

Receive screen capture

screen_shot_2018-04-25_at_10_52_13

Send screen capture

screen_shot_2018-04-25_at_10_52_26

QRCode contents

_2018-04-25_11_03_25

Should support iPhoneX, if release to iOS AppStore

Description
Apple say "All new apps for iPhone, incuding universal apps, must Suppor the Super Retina display of iPhoneX" (See: https://developer.apple.com/ios/submit/ )
But NEMPay do not support iPhoneX. When do not support iPhoneX, app content has margin top and bottom. (like Capture: NEMPay on iPhoneX).
If supported iPhoneX, App content has not margin. (like Capture: Supported iPhoneX app).
When release to AppStore, we should support iPhoneX. if do not support iPhoneX, NEMPay rejects from AppStore by Apple.

Capture: NEMPay on iPhoneX

screen_shot_2018-04-25_at_13_44_14

Capture: Supported iPhoneX app.

screen shot 2018-04-25 at 13 44 55

Account import can not be done with QR when newly registered.

Expected Behavior
Select account import on the new registration screen.
QR leader is started with "loading of QR (display in English is unknown)".

Current Behavior
The QR reader does not start.

Steps to reproduce
Select account import on the new registration screen.
Press "Capture QR (Do not know the display in English)".

screenshot_20171023-024436

Even if you press send button via Address book, you can not proceed to the next screen.

Expected Behavior
Select 1 person in Address book and press send button.
A transmission screen addressed to the selected address or a selection screen of the mosaic is displayed.

Current Behavior
Select 1 person in Address book and press send button.
At the center of the screen, "Please Wait" is forever displayed.

Steps to reproduce
Select 1 person in Address book and press send button.

screenshot_20171023-184238

Nothing happens when pressing the QR Load button.

Expected Behavior
Pressing the QR reading button activates the QR code reader.

Current Behavior
Nothing happens even if you press the QR reading button.

(Only account import, QR works)

Steps to reproduce
Press the QR reading button in the upper right.

screenshot_20171011-044723

Even if an existing account is imported with QR, it returns to the original screen without being registered

Expected Behavior
When the QR code is read, a password input screen is displayed.
After entering the correct password, the account is added.

Current Behavior
After QR reading, "Necessity to enter password" is displayed.
However, there is no input screen and I will return to the registration screen.

(Just a pattern that JSON loaded with QR is copied to the clipboard)

Steps to reproduce
Register account โ†’ Capture QR

As a creator of a non-transferable mosaic, I want to be able to send them.

Expected Behaviour
When trying to transfer a non-transferable mosaic, if I'm the creator, it should be allowed to transfer it.

If I'm not the creator, it should allow to send it only if the recipient it is his creator.

Current Behaviour
Right now it appears an alert spotting that the mosaic it is not transferable.

Steps to reproduce
Go to Balance.
Select a non-transferable mosaic.
Click transfer button.

In the address book, only the first letter is checked

Expected Behavior
Register after confirming whether the address is official as NEM

Current Behavior
If the beginning is T or t, any short character string can be registered.

Steps to reproduce
Register the name and address in the address book.

screenshot_20171011-051847

Copy address from transaction list it is not working on Android

Expected Behaviour
When a user press a transaction, recipient or sender address is copied to the clipboard.

Current Behaviour
In iOS is working well.
In Android seems to not be clickable.

Steps to reproduce

  1. With an Android device, open the app, import an account.
  2. Go to Transactions tab.
  3. Click to any transaction.

On the transaction list screen, "Privete key has been copied" is displayed without any meaning.

Expected Behavior
Even if you click on a place other than the menu on the screen on the transaction list screen, nothing happens.

Current Behavior
At the bottom of the screen, "Privete key has been copied" is displayed.
Repeat the display for the number of times you hit repeatedly when you hit repeatedly.

Steps to reproduce
On the transaction screen, click the part which seems to be unresponsive normally.

screenshot_20171023-024247

Sending using QR code lets into the wrong amount

Steps to reproduce

  1. Open Nanowallet > Services > Create an Invoice
  2. Insert amount to 1
  3. Open NEMPay > Balance > Send > Scan QR
  4. Scan QR

The amount in NEMPay is 1000000.

Desired behaviour

The amount in NEMPay should be 1.

There is a part which is not multilingual.

I got a screen copy of the part not multilingualized.
English language files and Japanese language files have the same number of lines.
And all Japanese language files are converted to Japanese and English is not left.

2017-07-16 22 39 23

2017-07-16 22 40 50

2017-07-16 22 42 37

If possible, I would like you to display it in local time.
2017-07-16 22 43 27

2017-07-16 22 44 07

2017-07-16 22 45 41

2017-07-16 22 48 18

About display of secret key (at the time of new account creation and usual use)

Expected Behavior
Originally it writes the secret key on paper.

Current Behavior
I can not copy it by selecting private key.
Many people are supposed to take screenshots.
Screenshots are accessible from many applications.
In order to avoid vulnerability, I want to put a warning to avoid screenshots.
In reality, there are few people who make notes on paper, so I think that it would be better to make it copyable to the clipboard.

Steps to reproduce
Screens for creating accounts and scenes for viewing secret keys in login state.

screenshot_20171011-044013

screenshot_20171011-044248

ADD multisig transactions in Transactions List

Expected Behaviour

When a user press a transaction list, and it has a multisig transaction, must be shown to the user.

That would be useful, so PacNEM users could see mosaic transactions sent through the game.

Current Behaviour

The app does not show multisig transactions.

How to build?

Current version is on Testnet
we have changed it to mainnet, test it and now how to build?

build command for android and ios get some error....

As a user, I want to be able to decrypt messages (transaction)

Expected Behaviour
When displaying a transaction with an encrypted message, the user should be able to insert the wallet password and display the message.

Current Behaviour
Right now it appears "ENCRYPTED" string.

Steps to reproduce
Go to Transactions tab.
Look for an encrypted transaction.

HEX string is garbled

Expected Behavior
Message is displayed like the attached second image

Current Behavior
It becomes like the image of the attached first sheet.

Steps to reproduce
Make a transaction that sends HEX string beforehand.
Look at the transaction list screen.

Other
The HEX character string could be sent by NCC.
In NanoWallet, HEX transmission is omitted.
Since it can be used in API, Mainfaucet et al., HEX format string message is active.

Image 1

screenshot_20171026-124136

image 2

2017-10-26 13 01 18

Nempay sees transferable mosaics as non-transferable mosaics

I am running on testnet and I have a bunch of mosaics that I have created that I guarantee are transferable. When I open up my wallet in nempay these mosaics are considered to be non- transferable and I can't send them.

Not all transferable mosaics are seen to be non-transferable by Nempay though.

Nempay sees to be NON-transferable:

  • Mutable supply: False
  • Transferable: True

Nempay sees as TRANSFERABLE:

  • Mutable supply: True
  • Transferable: True

Steps to reproduce:

  • Login app
  • Lands in 'Balance' page
  • Choose a transferable mosaic (Transferable: True)
  • Press send
  • Alert pops up saying "Selected Mosaic is not transferable"

Processing when there is no account on the account selection screen

Expected Behavior
If you do not have an account and try to select an account, pop-ups with no choice are displayed.

Current Behavior
If the account does not exist, even if you select an account, it is nonresponsive and has no problem.

Steps to reproduce
Select an account without creating an account.
An account selection screen without choices is displayed.

Wallet address (receiving) is not visible

I cannot read the whole receiving address of the wallet (the field only shows the beginning of the string and ...), only by using the QR code. If I want to transfer from nano wallet I cannot do it.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.