dgm9704 / xoxo Goto Github PK

This results in every context in compared instances being "different", which is true from a purely technical point of view. However it would better if the entity is compared only once per comparison (plus of course checked to be consistent across the instance) and contexts compared only by scenarios. The above holds also for period.
This would result in a situation where two otherwise functionally identical reports with differing entity (or period) would not report each and every context (and fact!) as different. Instead, the report would simply state that the entity (or period) is different and leave it at that.

eg. "0.0000" and "0" are considered different when both are possible and correct representations of fact value.

... this results in difference being reported when functionally same instance.
The comparison should be skipped when other instance (or both) doesn't have taxonomyversion,
since it isn't mandatory.

Scenario argument should perhaps be allowed as null

So basically need to implement reading of processing instructions when deserializing

Facts can be equivalent in other ways and have different values for Decimals. In some cases these facts should be seen as being same.

When comparing FilingIndicator collections, filed=false should match missing filing indicator

http://www.xbrl.org/specification/streaming-extensions-module/pwd-2013-03-06/streaming-extensions-module-pwd-2013-03-06.html#term-streamable-instance

http://specifications.xbrl.org/work-product-index-streaming-extensions-streaming-extensions-1.0.html

There should be some way to tell where the differences(s) are, like reading a property after comparison, or giving an optional out parameter, logging the differences to a stream, throwing an exception with details or something. At the moment it's just a true/false which doesn't help much with any substantial instance.

In some cases it's know beforehand that instances are going to differ eg by entity or period, but should be otherwise identical. These cases are now reported as different. Since the basic comparisons are already separated in logic, there should/could be switches for them also.

Not fixed, still need to do the same for Scenario.ExplicitMemebrs and .TypedMembers

System.NullReferenceException: Object reference not set to an instance of an object.
at Diwen.Xbrl.Fact.Equals(Fact other)
at System.Collections.Generic.GenericEqualityComparer1.Equals(T x, T y) at System.Collections.Generic.LinkedList1.Find(T value)
at Diwen.Xbrl.ListExtensions.ContentCompareReport[T](IList1 left, IList1 right)
at Diwen.Xbrl.InstanceComparer.FactComparison(Instance a, Instance b)
at Diwen.Xbrl.InstanceComparer.Report(Instance a, Instance b, ComparisonTypes comparisonTypes)
at XbrlCompare.Program.CompareAndReport(String inputReport, String outputReport, String comparisonReport, ComparisonTypes comparisonTypes)
at XbrlCompare.Program.Main(String[] args)

ie: <xbrli:scenario />
instead it should not be serialized at all

Object reference not set to an instance of an object.
at Diwen.Xbrl.InstanceComparer.CheckEntity(Instance a, Instance b)

Other instance is empty (has no contexts or facts), other has no facts but has a context (for filing indicators)

RemoveUnusedContexts() gets IEnumerable and calls Contains multiple times. Should probably call ToList() first

Two cases with facts differing by value, only first is reported. Facts have same context but different metric. If one is fixed then other is reported.

example instance:

<?xml version='1.0' encoding='utf-8'?>
<?taxonomy-version 2.0.3?>
<xbrli:xbrl xmlns:xbrli="http://www.xbrl.org/2003/instance" xmlns:link="http://www.xbrl.org/2003/linkbase" xmlns:xlink="http://www.w3.org/1999/xlink">
  <link:schemaRef xlink:type="simple" xlink:href="http://www.eba.europa.eu/eu/fr/xbrl/crr/fws/corep/its-2013-02/2014-07-31/mod/corep_con.xsd"/>
</xbrli:xbrl>

link to xsd:
https://www.xbrl.org/2003/xbrl-instance-2003-12-31.xsd

excerpt:

<element name="xbrl">
<annotation>
<documentation>XBRL instance root element.</documentation>
</annotation>
<complexType>
<sequence>
<element ref="link:schemaRef" minOccurs="1" maxOccurs="unbounded"/>
<element ref="link:linkbaseRef" minOccurs="0" maxOccurs="unbounded"/>
<element ref="link:roleRef" minOccurs="0" maxOccurs="unbounded"/>
<element ref="link:arcroleRef" minOccurs="0" maxOccurs="unbounded"/>
<choice minOccurs="0" maxOccurs="unbounded">
<element ref="xbrli:item"/>
<element ref="xbrli:tuple"/>
<element ref="xbrli:context"/>
<element ref="xbrli:unit"/>
<element ref="link:footnoteLink"/>
</choice>
</sequence>
<attribute name="id" type="ID" use="optional"/>
<anyAttribute namespace="http://www.w3.org/XML/1998/namespace" processContents="lax"/>
</complexType>
</element>

...so when there are problems, you would at least get some output

Assert.Fail failed. System.NullReferenceException: Object reference not set to an instance of an object.
at Diwen.Xbrl.Fact.ToString()
at Diwen.Xbrl.InstanceComparer.FactComparison(Instance a, Instance b)
at Diwen.Xbrl.InstanceComparer.Report(Instance a, Instance b, ComparisonTypes comparisonTypes)

-> In Fact.ToString() check for Metric, Unit and Context being null

Seems to come from trying to get Scenario.ToString() when scenario is null

ie. these should be equal cases and are not atm.
a)

  <xbrli:unit id="uEUR">
    <xbrli:measure>iso4217:EUR</xbrli:measure>
  </xbrli:unit>
<eba_met:mi290 unitRef="uEUR" decimals="-3" [...]

b)

  <unit id="u-01">
    <measure>iso4217:EUR</measure>
  </unit>
<eba_met:mi290 unitRef="u-01" decimals="-3" [...]

Two facts can be equivalent but have values differing only by trialing decimal zeroes. In some cases these facts should be seen as being same.

... and everything else use double quotes