dgonzo27 / py-iot-utils Goto Github PK

• Package Name: iot-ftps-client
• Package Version: 1.1.1
• Operating System: Windows 10 64bit
• Python Version: 3.10

Describe the bug
Connecting to Bambu Labs X1C ftps server, which appears to be running vsFTPd 3.0.3 based on the welcome message, get an error unexpected exception occurred: 522 SSL connection failed: session reuse required when attempting to do something simple like ftps_client.list_files("/"). Trying to upload a file I get unexpected exception occurred: EOF occurred in violation of protocol (_ssl.c:2426)

To Reproduce
Steps to reproduce the behavior:

1. Used this code to connect and attempt to list and upload file.

from iot.ftps.client import IoTFTPSClient

ftps_client = IoTFTPSClient(
    ftps_host="myServerIP",
    ftps_port=990,
    ftps_user="myServerUsername",
    ftps_pass="myServerPass***",
    ssl_implicit=True,
)

ftps_client.list_files("/")

ftps_client.upload_file("C:\\Users\\jneil\Documents\\3D Prints\\PrinterUprades\\OrdBotHadron\\OctoprintRelated\\printer-ws-client\\bambu_local\\test.3mf", "/test.3mf")

Expected behavior
To be able to list and upload files.

Screenshots

Additional context
I'm able to connect and list/upload files using filezilla ftp client as described in the link below without issue, so know the login information is correct.

https://forum.bambulab.com/t/we-can-now-connect-to-ftp-on-the-p1p/6464

my username ashahbazi58

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A least recently used cache library.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

• copy a directory between containers
• copy a blob between containers
• move (cut and paste) a directory between containers
• move (cut and paste) a blob between containers

Is your feature request related to a problem? Please describe.
Yes, I would like to be able to perform some additional common Azure Storage operations, but I don't want to subclass this package or write my own. I'm requesting that these functions are added to the iot-storage-client package.

Describe the solution you'd like
New Functions:

1. Copy between containers within the same storage account
2. Move (cut and paste) between containers within the same storage account
3. Download/Copy from a SAS url
4. Generate account SAS url
5. Generate container SAS url
6. Generate blob SAS url

Describe alternatives you've considered
I considered sub-classing the package to add this functionality myself, or adopting this code and establishing my own package with the added functionality. It would be much cleaner to have this available through the existing package.

To-Do List:

• copy between containers within the same storage account
• move (cut and paste) between containers within the same storage account
• download/copy from a SAS url
• generate blob SAS URL

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Create a function that generates a container-level SAS token/URI

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

• async client
• better testing
• better docs

Looking at source. Isn't calling iot-ftps-client a FTPS client highly incorrect or even fraud, if it uses insecure plain FTP when instantiated without ssl_implicit=True? Sorry if I am wrong.

• GitHub releases trigger a workflow, pushing to PyPI
• Security template
• Issue templates (bug, feature, contribute)
• Contributing Guide
• Code of Conduct
• Consistent Docs and README's throughout
• Project Email
• update code of conduct, root readme, and security template w/ project email.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

• Package Name:
• Package Version:
• Operating System:
• Python Version:

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

improve documentation

• logging considerations
• ideal scenarios/use-cases
• example architecture
• contributor guide
• local development
• test commands

develop unit tests

• test for package versioning and config
• test for logger format and levels related to syslog
• integrate testing into CI/CD

At least 80% code coverage for each packages test suite.

• iot-edge-logger
• iot-edge-validator
• iot-samba-client
• iot-sftp-client
• iot-storage-client

Is your feature request related to a problem? Please describe.
We need to transfer files on the edge with an SFTP server.

Describe the solution you'd like
We need to transfer files on the edge with an SFTP server.

Why would you like to contribute to this project?
As a lead developer on an enterprise IoT Platform, I would love to contribute to this project as I leverage and use all of these packages in our platform. Allowing me to contribute would offer valuable insight into industry adoption while simultaneously allowing me to support stateless interactions that can be leveraged outside of our platform.

What are your qualifications?
You know me - I wrote this thang.

What are you looking to contribute and how many hours per week?
Probably 6 - 10 hours per week, looking to contribute new features, maintenance and documentation.

Do you understand that these contributions are open-source and there is no pay for contributing?
Yes.

• Package Name: iot-ftps-client
• Package Version: 1.0.0
• Operating System: Ubuntu 18.04 Linux
• Python Version: 3.9.5

Describe the bug
A clear and concise description of what the bug is.

When leveraging the upload_file function, the storbinary call attempts to read the file from within an open context. It should simply pass the bytes of the opened file instead of reading - this currently causes the function to fail.

To Reproduce
Steps to reproduce the behavior:

1. Upload any file to an FTPS server with the upload_file function of the iot-ftps-client.

Expected behavior
A clear and concise description of what you expected to happen.

File upload success.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.