dhcgn / encryption-suite Goto Github PK

Source: dhcgn/ECC-HSM-Encryptor#19

• strictly set required and optional
• Create proto files
• Update readme.md
• Add diagram to readme.md

Some unit tests are calling methods which are marked as obsolete.

Add a powershell module with this features:

• Symmetric Encryption
  • Password based encryption
• Hybrid Encryption
  • Public Key in ANS1
  • Cred. obj. for PIN
• Report progress

An (optional) action should return to observer

• Status (String or Enum)
• Percent if possible

So https://github.com/dhcgn/ECC-HSM-Encryptor can be used without a nitro key,

Definition of Done

• Implementation
• Pathfinder (CC)
• Unit Test
• Documentation

This was only implemented as proof of work but to must be changed for to reach beta status.

At the moment a temporal file is written (and deleted) at each encryption/decryption operation.

• No filesystem io during encryption/decryption

Actual

Because we know the HMAC after encryption, the InformationContainer can only be serialized at this moment. This ensures that this poor design has been implemented for the first prototype.

----------
File Signature
---------
Length of Serialized ProtoBuf 
---------
Serialized ProtoBuf (see InformationContainer)
    - among other things the HMAC
---------
Encrypted Data
---------

[ProtoContract]
internal class InformationContainer : ProtoBase<InformationContainer>
{
	[ProtoMember(1)]
	public PublicInformation PublicInformation { get; set; }

	[ProtoMember(2)]
	public PasswordDerivationSettings DerivationSettings { get; set; }

	[ProtoMember(3)]
	public byte[] SecretInformationData { get; set; }

	[ProtoMember(4)]
	public EllipticCurveEncryptionInformation EllipticCurveEncryptionInformation { get; set; }
}

Ideas

1. Don't put the HMAC in the InformationContainer.
   e.g.

----------
File Signature
---------
Length of Serialized ProtoBuf 
---------
Serialized ProtoBuf (see InformationContainer)
---------
HMAC
---------
Encrypted Data
---------

The type FileCargo does contain optional information for the decryption process.
Name is inadequately for its usage.

• Change name
• Update proto files
• Update readme.md

The unit test should include:

• wrong AES Key
• tamperd HMAC
• tamperd Data
• tamperd IV

Migrate all projects to netcoreapp2.1.

Was removed with 35a0c37 because file format was changed.
File: https://github.com/dhcgn/Encryption-Suite/blob/3eadc6bea0864a1de75012ccf8e1db1c71900091/src/Encryption.Test/TamperTest.cs

The following should be included:

• AesKey
• HMAC Hash
• IV
• Encrypted file

see also #1

There should be only one 'meta type' for hybrid and normal encryption.

ref dhcgn/ECC-HSM-Encryptor#7

ref #28

Support common file format for the result file.

• the original file should be stored encrypted

Current state is confusing.

• Key derivation
• Meta information (private data)
• Crypto information (public data)
• Hybrid encryption