dhowe / adnauseam Goto Github PK

Vault shows 4 ads but lists 5:

Should read: "AdNauseam says"...

If 'open-vault' is clicked while vault is already open, we should switch to that tab, rather than opening it again.

Need a manual refresh of the vault page after Clear Ad to correctly shows the status.

In this case, the tab still maintains its previous badge count after all ads have been cleared:

• Using a browser without extension, manually identify 10 sites (from the 100 top sites list) with ads that are visible without scrolling
• Then check each with current adn2, and note how many of the total count where found by adn2.

Need to be able to disable AdNauseam for a page, a site, or entirely (although this last is already handled in the browser's extension manager).

Describe the issue

Soon after ADN 2.0.1 (take1) is installed on Chrome Version 48.0.2564.116 (64-bit) (OSX 10.10.5) it slows down to a level that makes it unusable

I've tried disabling other extensions, it doesn't help.
The browser frees up again as soon as ADN is deactivated.

Can someone verify that https://adnauseam.io/ does not load in the browser...

• Better Ad Detection (check nytimes.com)
• Badge count updating
  • whenever a new ad is found
  • whenever the user switches tabs
  • whenever clear ads (including the deletion using right click) (see #41)
• Menu/Settings button goes to combined settings page
  • open settings page in new tab instead of new window (see #22)
• Import ads
  • support for legacy ad import files (see #37)
• Export ads
• Clear ads (does not consider badge count update) (see #55)
• Delete-Adset (via right-click) in Vault (does not consider badge count update) (see #56)

....

Think SETI at home for ad clicking.

This will require a cross platform way of identifying idleness. Depending on its performance this will be set as an opt in or opt out option.

Even the original gorhill/ublock does not support Safari version.
I think we should stop developing Adnauseam on Safari.

Steps to build for Safari:

$ git checkout c7f1027ab96e72bc60ed63be7d6df4c227ee6713
$ tools/make-safari.sh

Load the extension on Safari from dist/build/ublock0.safariextension

see your comment in #14

However if I use the Clear ads button from the settings page the menu is updated (showing empty ad list in the menu)

Need to identify event-handler in ublock for when the activetab changes
Then call uBlock.adnauseam.updateBadge();

You might be able to find these in an earlier (adn1) ticket.
But we need 5-10 current examples of pages with text-ads (not including google-search)
You can test these with uBlock, by disabling 'cosmetic-filtering' in the uBlock menu.
Once disabled, text-ads should appear.

Should read "Show Adblocker Dashboard", and "Show Adblocker Logger" (not sure if this needs to be changed in Chrome/Opera as well (please check). And description should be changed as well (these changes likely relates to #21). .

deleteAd: #1 pre-total: 1
post-total: 1

see core.js::420

For vault and menu. Need the correct/standardized progression of css classes (the set of classes for both image and text ads that an item should have) for the following events:

AdAttempted ->  AdVisited-Success
                          ^
                          |
AdAttempted -> AdVisited-Failure (#1, #2, #3) -> GiveUp

For example:

1. Resting: ad-item
2. On-Attempt: ad-item attempting
3. On-Success: ad-item attempting just-visited visited
4. Resting: ad-item visited

Please also check that this is standardized between the vault and menu

Appears to be the frame-title ("SafeFrame Container") rather than the page-title...

Need to test in contentscript-end.js whether we can get the title of the root document

window.self !== window.top;

Setup (OS X)

1. git clone https://github.com/dhowe/AdNauseam.git
2. git clone https://github.com/dhowe/uAssets.git
3. Install `jq` if you don't have it (https://stedolan.github.io/jq/)
4. cd AdNauseam

On Chromium / Opera (Mac OS X):

1. Build the extension in Terminal
   $ tools/make-chromium.sh
   or
   $ tools/make-opera.sh
2. Open the browser and go to settings, with URL chrome://extensions/ (also works on Opera)
3. Enable Developer mode in the settings page and load extension from /bin/build/adnauseam.chromium or /bin/build/adnauseam.opera

On Firefox (Mac OS X):

1. Open Firefox and go to about:config, then set xpinstall.signatures.required to false
2. Make sure you have jpm installed
3. In terminal:$ tools/run-ff.sh
4. (Optional) To use a Firefox profile other than default, pass the profile path to run-ff.sh:
   $ tools/run-ff.sh path/to/profile

seems data-width is not getting set correctly on layout...

@mushon we need a place for these buttons

Need to:
a) find a list of trackers-only (not ads) see #34
b) identify when a block would occur from this list -- can we associate a block pattern with the list it came from?
c) implement the block if on a tracking list
d) test that we can still capture all ads as usual

Adding them to the vault will cause a reload of all ads (so that packing can occur). The other option is ignoring them.

Works correctly in Chrome, but not in Firefox or Opera. Appears to be some tricky CSS.

To test, run FF version, click "open advault" or "settings", notice that it opens (incorrectly) in a new window. uBlock has this working correctly for their logger view (see: https://github.com/gorhill/uBlock/blob/master/src/popup.html#L21).

Describe the issue

Still shows "uBlock Origin" instead of "AdNauseam" before or after the PR: #35

This will be quite useful for debugging -- we will need to decide whether such access is also useful to users, and if so, add it into the ADN Menu UI

actually neither the 'attempting' animation, or the 'just-visited.failed' animation are firing on the 2nd and 3rd visit attempts

This comes up most commonly on page-refresh.

Currently, we consider an ad to be new if it is unique or if it is a duplicate that was discovered more than 'repeatVisitInterval' ms ago, currently set to 1 minute.

We need a uBlock or ABP ad-blocking list containing ONLY(invisible) trackers, with no visual ads.

See 'filters' variable and GoogleText example in src/js/contentscript-end.js

Need to check this in content.js

...

Error: vault.js:967 Uncaught ReferenceError: e is not defined

along with ADN's import/export ads buttons

After opening vault: