Currently it needs quite a lof of code to run; most of that can be made part of the mo

Draft PR in the exploration repo: <a class="issue-link js-issue-link" data-error-text=

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Make movie reviews model easier to run about dianna HOT 5 CLOSED

dianna-ai commented on August 10, 2024

Make movie reviews model easier to run

from dianna.

Comments (5)

loostrum commented on August 10, 2024

Leaving as-is for now, we should talk to an NLP expert first to see how models are normally used.

from dianna.

loostrum commented on August 10, 2024

The input to the model should remain text, but the functions to create tokens from the input string will be made part of the model. The goal is to avoid having to define a lot of boilerplate code in the dianna repository just to be able to run the model.

from dianna.

loostrum commented on August 10, 2024

Draft PR in the exploration repo: dianna-ai/dianna-exploration#147
The pytorch model is working, but after conversion to onnx it fails because there are no inputs.
Possibly related issue: pytorch/pytorch#44299

from dianna.

loostrum commented on August 10, 2024

We will not use the simplified model as it doesn't work. This issue can be closed when the simplifications that don't affect the onnx model itself are merged in dianna-exploration.

from dianna.