`includeError` displaying errors as `"[Array]"` about apollo-link-sentry HOT 10 CLOSED

The operation name and type indicate this is definitely version 3. I will begin working on a PR to restore nice serialization of errors right now.

from apollo-link-sentry.

@alesso-x you have some valid points, but could you open discrete issues? I think that would be more productive than us discussing in this closed issue 😉

from apollo-link-sentry.

How about includeFetchResult: 'on-error' as a third option?

from apollo-link-sentry.

Hi, since we recently went through a breaking update, it would be helpful to know which version of the package you're using.

from apollo-link-sentry.

@spawnia it seems like you removed the following code in the rewrite:
https://github.com/DiederikvandenB/apollo-link-sentry/blob/v2.1.0/src/utils.ts#L13-L15

I think adding this back would resolve the issue. At the very least, it will format the error better.

from apollo-link-sentry.

Serialization of fetchResult seems to be broken in the same way:

from apollo-link-sentry.

Thank you @DiederikvandenB @spawnia, I can now see the errors formatted correctly!

I have a follow up question and it might be a feature request. I can see the error nicely now but if I wanted to see the results I would have to enable includeFetchResult. That config changes all request to show the fetch result but I only want to see it for errors. Could we have a config var to only show fetch results for errors? Or is there another way I could do this on the client side with the transform function? I could also submit a PR if that makes easier. Thank you again!

from apollo-link-sentry.

How about includeFetchResult: 'on-error' as a third option?

I like that idea

from apollo-link-sentry.

How does Apollo Client behave when it receives a 200 that also has errors, will it call .error() or .success() on the subscriber? And how should we handle that? I think there is no hard and fast rule to know if those errors are something actionable.

from apollo-link-sentry.

How does Apollo Client behave when it receives a 200 that also has errors, will it call .error() or .success() on the subscriber

I'm not sure, I would need to test it out. For now I'm able to see graphQL errors by adding a breadcrumb in a errorLink. If we could follow that, I think that would work for me.

Also I had to disable transaction name in the plugin because it would override every error. For example I threw an error in a button and it would set the operation name to the query when the query was successful (the second issue is what it should look like). I think it makes sense to scope many of these options to errors. I have includeQuery enabled for every request.

For completeness, here is my config for SentryLink. So far this setup is working for me but it would be nice to have all the config in SentryLink instead of a custom errorLink.

const sentryLink = new SentryLink({
  setFingerprint: false,
  setTransaction: false,
  attachBreadcrumbs: {
    includeQuery: true,
    includeError: true,
  },
})

from apollo-link-sentry.