Issue:

• When the page is on mobile and the users click on the hamburger button, if you resize the website to desktop, the menu does not get back to the desktop version, instead keeps the mobile layout, which should not happen.

Suggested Changes:

Social Icon media include severla icons, but in order to reduce repetition on style, you could map like this example:

import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faEnvelope } from '@fortawesome/free-solid-svg-icons'
import {
  faXTwitter,
  faLinkedinIn,
  faGithub,
  faAngellist,
  faMedium,
} from '@fortawesome/free-brands-svg-icons';

const SocialMediaBar = () => {
    const GITHUB_URL = 'https://github.com/Diegogagan2587'
    const LINKEDIN_URL = 'https://www.linkedin.com/in/diego-vidal-lopez/'
    const TWITTER_URL = 'https://twitter.com/dieg02587'
    const ANGELLIST_URL = 'https://wellfound.com/u/diego-vidal-lopez'
    const MEDIUM_URL = 'https://medium.com/@diego27796gagan'

  return (
    <div id="social-media" className='flex flex-col gap-4'>
      <span className="text-base font-medium text-[#7F8CFF]">
        LET&apos;S CONNECT
      </span>
      <ul className="h-5 flex gap-5 items-center text-xl text-[#505F79]">
        {[
          { url: GITHUB_URL, icon: faGithub },
          { url: LINKEDIN_URL, icon: faLinkedinIn },
          { url: TWITTER_URL, icon: faXTwitter },
          { url: ANGELLIST_URL, icon: faAngellist },
          { url: MEDIUM_URL, icon: faMedium },
          { url: 'mailto:[email protected]', icon: faEnvelope },
        ].map((item, index) => (
          <li
            key={index}
            className='hover:drop-shadow-2xl hover:scale-125 active:animate-ping transition-transform duration-300'
          >
            <a href={item.url} target='_blank' rel='noreferrer'>
              <FontAwesomeIcon icon={item.icon} />
            </a>
          </li>
        ))}
      </ul>
    </div>
  );
};

export default SocialMediaBar;

Suggested Changes

• According to your experience so far, hiring managers are looking for documentation skills, and you have been documenting all your work from the beginning, so it is worth adding it. Somre others skills you could consider to add:
  • Heroku
  • Github Pages

This Issue is created according to the morning session week 3 - Codereview; The team will include some suggestions, they will take a look over the closed pull: request #5 for the last 5 commits.

Issue

When you hover the Mouse over the button it moves slightly to the right, That should not happened.

Suggestd Changes:

If you go to https://pagespeed.web.dev/analysis/https-dvloper-z-com/sn25m7ubpl?form_factor=mobile You notice the portfolio still has 3 areas of improvement, would be great if we could improve:

• Performance
• Accessibility
• SEO

Suggested Changes:

It's important to keep track of visits to know what we need to improve in this portfolio, that's why I suggest adding a tracking system, one option to do it could be to follow this guide provided by FreeCodeCamp:

• How to set up performance and user tracking in React with Google Analytics
• another option could be use to use Google Tag Manager(Data collecting tool) + Google Analytics(Data viewer or data analysis tool), below there is a video explaining both:
  Google Tag Manager Tutorial for Beginners (2024) with New Google Tag

This issue is intended to explain that the project was already deployed. The readme is up-to-date including the link to the live website. You can take a look over the website here:

https://diegogagan2587.github.io/Diego-Vidal/#

You can verify the readme here:

https://github.com/Diegogagan2587/Diego-Vidal/blob/main/README.md

thanks for reviewing.

Suggested Changes:

• When the user hovers a project card, the animations are not smooth, making a smooth transition
  might improve user experience, and probably, catch attention of a recruiter
  

-This is intended for completing the first exercises from day2 week 2,

Suggested Implementations

About Myself Section

• When users click on a group of skills it should turn the arrow, pointing to the bottom:

Suggested Changes:

Update Readme

Currently, every time users click on the live demo, it redirects to https://dvloper-z.com/Diego-Vidal/, and GitHub Pages is returning a 404 error page. to fix it, we should update the link to https://dvloper-z.com in the docs(I mean in the Readme).

Suggested changes:

I think would be great if we include CRA(Create React App) in the skills sections, as a tool or methodology we know how to use, like Vite or Webpack.

• Would be better to put university selectors at the beginning to no repeat them a lot.
• use generalization on CSS, for example, private heading, we have defined multiple times the same font sizes, when we could just define a more general selector and apply it to all of those elements.