digemall / bsearchtools Goto Github PK

R (v3.4+) warns during "R CMD check --as-cran" when native symbols are not explicitly registered :

* checking compiled code ... NOTE
  Found no calls to: ‘R_registerRoutines’, ‘R_useDynamicSymbols’
It is good practice to use registered native symbols and to disable
symbol search.

Possible implementation: add in the index structure for each column the indexes of the NAs, then create a function EQNA(indexedColName) which returns the NAs.

Add drop argument support to DFI.subset, of course ignored if return.indexes = TRUE

DFI.subset ignoring return.indexes=FALSE when filter=NULL

e.g. :

D <- DFI(data.frame(A=1:10,B=21:30))
DFI.subset(D,filter = NULL, return.indexes = FALSE)
DFI.subset(D,filter = NULL, return.indexes = TRUE)
# the previous 2 lines return the same result but they should not

Should we add a warning when an indexed DFI column is modified ?
This means overriding all the data.frame and matrix replacement operators...

[<-.data.frame
$<-.data.frame
[[<-.data.frame
and the one used by matrix objects

print.DFI function does not work properly when DFI object wraps a matrix instead of a data.frame

e.g. :

m <- matrix(1:10,nrow=5)
colnames(m) <- c('A','B')
D <- DFI(m)

> print(D)
NULL
<0 rows> (or 0-length row.names)

INDEXES:
A
B

This info is currently missing from the DFI documentation.

NOT operator does not work anymore in version 0.0.47

Fix and add a test in alltests.R

e.g. executing the following code it does not print anything on the console

print(EQ('a',1))