digitalbitbox / bitbox-api-rs Goto Github PK

wasm-pack produces the NPM package from Rust, adopting the version from Cargo.toml.

Both libraries should have their own versions and changelogs, as it is likely that sometimes one is changed but not other. Already happened with v0.1.6 where a Rust type was made public that did not affect the NPM lib.

Idea for solution: add a NPM-VERSION file that contains the version for NPM, use jq to patch the package.json using this version using in make wasm.

Sorry I am in conference week, so I am quite sporadic on my work.

difficult otherwise to make external implementation of NoiseConfig trait

I tried to use the library in a React app and added the required WebPack config but I still get an error when using it (wasm.bitbox02ConnectWebHID is not a function). The WASM file is copied to the static/media folder during build.

Am I missing something?

It could be very useful if devs and users could visit a live deployment of the sandbox webapp without having to compile it.

Ideally it is deployed automatically when things are merged master.

Deploying using GitHub Pages for this repo could be best.

This repo contains both the Rust package and the NPM package. To accomplish this, we are swimming against the tide quite heavily:

• hack about separate READMEs for NPM, the GitHub page and Rust: #36
• hack about having separate versions for each: #57
• we would add prefixes to the version tags going foward (rust-x.y.z etc).

Now that we have all of this we could roll with it, but by now I got the feeling that we should have just done it in separate repos, where the NPM repo just includes the Rust package as a dependency. Then all the above workarounds become unnecessary.

The workarounds above incurs a mental overhead to anyone looking at this repo - separate repos would be straight forward to understand and work with.

Potential downside: development of new features could be a bit more difficult as one would have to use a dev-version of the Rust package in the NPM repo to develop a feature in both repos at once.

Also is it possible to add #[derive(Clone)] to NoiseConfigData ?

I just saw that the btcSignMessage call is missing. Do you plan to add it?

The error message does not fit into the message box in BitBox sandbox UI, it exceeds the screen borders. Therefore they can not be fully read. Attaching a screenshot for this below: