digitalearthafrica / deafrica-scripts Goto Github PK

This comment is wrong: https://github.com/digitalearthafrica/deafrica-tools/blob/42c4a87789ff387510016edb4a53b0fa4f666f2a/monitoring/tools/s2_gap_report.py#L176

The --dev flag should be setting the BUCKET, really. It is only used to switch to this SENTINEL_2_STATUS_REPORT_PATH

Please re-think all the CAPS variables. Some don't need to be set, some should be in the environment of the process.

Please re-think the naming of things too, especially things like "COGS_REGION". What is this really? (The answer is that it's the Sentinel-2 source bucket region.)

Comment is wrong here: https://github.com/digitalearthafrica/deafrica-tools/blob/main/monitoring/tools/s2_gap_report.py#L147

The design of the project has a folder structure like <tool-type>/tools and <tool-type>/tests and there's no good place for common utils and so on.

I think it would be better just to have something like tools/monitoring and tools/data and tools/utils.py and so on. So that tools/tests could exist where there are tests for everything.

Anyhow, a better structure would be nice.

Hello,

I would like to run this container in -it mode. I've got the image from dockerhub repository using docker pull, and now I'm trying to run it using the following docker run command:

docker run -it -p 8080:8080 --name africa -v /home/user/projects:/code digitalearthafrica/deafrica-scripts

but it just runs and stops, just printing the following Python 3.8.10

I think sending the notification should happen only if tehre are > 200 scenes otherwise we'll get notified all the time.

Originally posted by @alexgleith in #27 (comment)

Because if there are 1 or more missing scenes it'll alert you on slack, so you can act on that. However, if there are more than 200 missing scenes it'll fail the task.

I believe we should be alerted any time that there is a missing scene or an orphan scene, so we can promptly run the gap report.
The rule for 200 scenes is following what was already applied on Airflow

Versioning is working according to python setup.py --version but not when it's built as a wheel.

It would be nice if it worked properly all the time!

Importing utils with utils.utils.thing is needlessly deeply nested!