Liquids not animating with Optifine, Liquids not animating in tanks about vanillafix HOT 19 CLOSED

Please make a single issue for issues that are related, such as animations being broken.

from vanillafix.

The entity on fire animation has already been fixed in the latest dev build (https://github.com/DimensionalDevelopment/VanillaFix/releases/latest).

I am not able to reproduce liquid animations being broken. Are you talking about vanilla water or modded liquid animations?

from vanillafix.

It seems like only vanilla liquids are affected, so lava and water. Also, my apologies for the title, this was actually my first time opening an issue on github :p

from vanillafix.

Hello,

Tinkers' Construct liquids aren't animated too.

(Latest versions from all mods I have installed)

from vanillafix.

Both Avaritia items and vanilla/modded liquids animate for me. Do you have Optifine installed by any chance?

from vanillafix.

My mod List (Yes, opti is installed)

from vanillafix.

After some further testing the liquid bug seems to weirder than I thought. It's quite hard to explain but I've made a video showcasing the issue. https://www.youtube.com/watch?v=XeD64tv-9nE&feature=youtu.be (Optifine isn't installed)

from vanillafix.

@vvnnif I'm not really sure what the bug is... I see both the sides and the top of all the liquids animating. The avaritia items also animate properly in your video...

from vanillafix.

@Runemoro The singularities aren't animated and the liquids are only animated at specific viewing angles https://youtu.be/XeD64tv-9nE?t=20

from vanillafix.

@ShadowofCubes It's impossible for VanillaFix to break animations from certain angles only. Also, I don't see the texture not animating from certain angles. I actually can't really see anything in that video since they keep moving so much.

What do you mean by the singularities?

from vanillafix.

Figured out the Tinkers issue. The texture isn't animated in the smeltery for some reason, but it is animated in the world. Since that isn't such a big issue, I think it's safe to cross that off the list.

We will look into fixing it, but it's on the back burner for the moment.

from vanillafix.

1 more example: Lava in OpenBlocks Tanks

If I focus the tank -> Lava is animated
If not -> not animated

from vanillafix.

@TheSnowyChickens Support for OpenBlocks tanks has been added in the latest dev build.

from vanillafix.

Support for Tinker's has also been added!

from vanillafix.

@vvnnif Vanilla liquids also animate correctly with latest Optifine and VanillaFix for me. Please comment on this issue if it's still a problem for you.

from vanillafix.

Just resolved this problem, wish I didn't have to spend few hours to do so though.
Running Forge 1.12.2-14.23.5.2768
Using The Unholy Quadfecta of Optimization: Optifine, BetterFPS, FoamFix, VanillaFix.
Animated textures just didn't work. Tried disabling OptiFine - didn't help. Tried additionally disabling FoamFix - didn't help. Re-enabled them, changed B:textureFixes to false - got them working. All of the four mods are up-to-date.
Please, help me help you find the cause. Maybe fixes from different mods are trying to do about the same thing and thus failing, maybe omething completely different. I will provide all the logs, dumps and other files you'll ask for, as long as the next guy who installs all 4 of these mods won't get to spend hours trying to get the textures to animate.

from vanillafix.

@Nordblum what exactly is your issue? Because I've done heavy testing and all my animated textures and fluids render properly without an issue.

from vanillafix.

@ZombieHDGaming I installed all 4 mods. Got into a fresh creative world. Didn't change a single setting, didn't touch a single line in mod configs - textures weren't animated. Water, Lava, Fire, Nether Portal - none of them. the only animated texture I could find is when I set myself on fire - that fire worked. I then started diffling with settings and combinations of them. Read of reddit that mipmapping isn't very cool with animated textures - checked twice and made sure it was disabled. Tried running all of these optimization mods, except FoamFix - still didn't work. Maybe it's some other mod breaking the animations, but for some reason, going into Mod Settings and setting textureFixes in VanillaFix' settings works. I turned it to false, restarted the game - texture animations, both vanilla and modded, work now.
We can go discuss this stuff on Discord if you'd like, that way when you show me that I'm completely wrong and the solution was simple all along I won't be made a fool of for everyone to see lmao.

from vanillafix.

This is unfortunately still an issue as @Nordblum described.

from vanillafix.