Giter VIP home page Giter VIP logo

vanillafix's Introduction

vanillafix's People

Contributors

aaron1011 avatar acgaming avatar creeper123123321 avatar democat3457 avatar hydrogenc avatar quantumstatement avatar runemoro avatar therandomlabs avatar wuzgxy-github avatar xuyuere avatar xxdark avatar zombiehdgaming avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vanillafix's Issues

Mod causes random damage tick

In survival mode, you randomly take damage for no reason at all while sprint jumping... The damage tick(ing) occurs while sprint jumping without falling from 3 or more blocks, and when these random damage ticks kill you, the death message is the fall damage death message.

This random damage ticking only happens while walking, sprinting, or sprint jumping, the random damage ticking has even cause game crashes before once the player dies from anything other than /kill, the crashing only happened in one world, the rest of my worlds you just die and nothing more happens.

Here is a video demonstration of the glitch happening in VanillaFix-1.0.4-35:

https://www.youtube.com/watch?v=GRcoXFyctLg&feature=youtu.be

(Note: The glitch DOES occur even when the mod is on its own, I did test the mod 100% by itself and it is causing this problem, and this also happens on any type of block)

Issues 29 and 32 (fall damage) "partially resolved"

The modification was tested in my modpack and in an isolated environment, not even Optifine was installed, only VanillaFix was installed on its own. I have even deleted the config files (I don't even know how that would help but I did delete them, and it did nothing).

I think that the bug was introduced in VanillaFix-1.0.4-35 and continues to persist to the current version of VanillaFix-1.0.6-53, all versions prior to VanillaFix-1.0.4-35 (VanillaFix-1.0.3-30 and under) did not have this bug.

The bug still occurs, but it seems to be a more uncommon occurrence, happening less often then the version(s) before.

However, at this point I just wonder if there is something stupid going on on my end.
Rundown of game specifications:
Mod version: VanillaFix-1.0.6-53

Edit:
I have upgraded to forge version Recommended 1.12.2 - 14.23.4.2703 and it is still the same.

Please stop using @Overwrite

From what I understand, when you use Overwrite, your mixin will not be compatible with any other mixin that modifies that method. Using Inject instead should lead to making your code significantly cleaner, and also fix those compat issues. It also means that any new changes Forge makes to those methods will be unintentionally reverted by your mod.

Landed Ender Dragon can still hurts entities

Minecraft Version: 1.12.2
Forge Version: 14.23.3.2680

In vanilla, the Ender Dragon doesn't cause any damage or fling entities while it's doing it's "landed" mode.

While having this mod installed. (Even only this)

When trying to fight the Ender Dragon while in it's "landed" mode , it can still damage entites. (You can even witness the endermen getting hurt by the Dragon while it's landed)

If you attempt to get closer to the "Landed" Ender Dragon, you'll get flunged like a couple hundred blocks away. (This is mostly noticeable in creative)

The hit-box for the Ender Dragon also feels a little janky with this installed, but i think that's just me. (I assume)

Default setting for S:scheduledTaskExceptionAction=WARNING_SCREEN, which crashes servers

When running VanillaFix on the server, it will occasionally cause a crash due to trying to load a GUI on the server (the welcome screen).

VanillaFix tried to show a GUI on the server, got java.lang.NoClassDefFoundError: net/minecraft/client/gui/GuiScreen

Full crash log

Possible Solution

Either
A) the default setting should be LOG, or
B) the mod should check which side it is on (client/server) before attempting to show a GUI (and preferably fall back to another method)

Cannot sleep after 1.0.3-30

Everytime i try to use a bed on overworld i'm almost imediately ejected and in the logs this appears

[02:46:43] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.125, 0.0
[02:46:43] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:44] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.125, 0.0
[02:46:44] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:46] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:46] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:47] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:47] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:49] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:49] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:51] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:51] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:52] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:52] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:53] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo tried to move while sleeping! 0.0, 0.0, 0.0
[02:46:54] [Server thread/WARN] [net.minecraft.network.NetHandlerPlayServer]: vicoo moved wrongly!

This is the only mod i've updated in my modpack (before i was able to sleep normally), so that's why i registered the issue here.
Forge b2691, 1.12.2

Merge safe fixes/enhancements into forge

While I understand that most things won't be accepted in forge because, there are also things that could easily go into forge. If it is in forge, every forge user will profit from these things and less ASM is always better because other mods that want to fix the same might have a problem with your mod, but they certainly will not have any problem with forge.
I would consider the following patches fitting for forge (you can at least try or tell me why not):

  • Tick only visible animated textures (huge FPS increase, up to 3x on very large modpacks)
  • Make interdimensional teleportation over 10x faster
  • Fix of MC-129057

A crash on 1.12 custom modpack when loading worlds

Well, hello there. At the time of writing this issue, I've been experiencing issues with VanillaFix mod. Literarly minutes after installing it, and launching my custom modpack, I ran in to an issue when trying to load any of the worlds, I have either generated before, or when creating new ones. The game keeps crashing. Looking at the crash log, it points out that cause of the crash is your mod, but the reason is unknown. By the usage of VanillaFix quick crashlog upload function (Ironically), I'm gonna leave the crashlog here aswell: https://paste.dimdev.org/ureyoserov.txt

Fall damage with Galacticraft's Hydraulic platform

it seem it is so buggy for some mod like Galacticraft's Hydraulic platform.
if you try to use this platform to get up or get down
The falling system will treat you as falling and give you damage.
It is work fine if you running the server without vanillafix
i think it also maybe incompatible with other mods.
So is there any option that we can disable the falling damage fix

Question about the Increased block and item ID limits.

My world was created using the NotEnoughId's mod, and I just want to make sure I don't mess something up horribly by updating VanillaFix while still using that mod. I tested it on a duplicate world, and it seems to work fine when just updating, but if I remove NotEnoughId's while using the update then minecraft crashes. So is it just a matter of feature overlap, or will it probably cause long term issues?

Incompatibility with LiteLoader

VanillaFix-1.0.4-35 , error on multiplayer server login

Internal Exception : java.lang.NoclassDefFoundError: net/minecraft/network/NetHandlerPlayServer

Windows 10 x64

Crash when placing ProjectX2 Xyrconium Bricks

VanillaFix version 1.0.6, started occurring at least on 1.0.4. ProjectX2 on latest, but has had this issue with VanillaFix since 1.0.4.

Anywhere the signature "noise" texture would be displayed is just clear. This leads to some items being completely invisible.

Fall damage prevention

The mod prevents the player from getting fall damage most of the times. Mobs are unaffected.
Tested on VanillaFix version 1.0.1-6 and Forge version 14.23.3.2655.

Don't forcibly set fml.coreMods.load

In VanillaFix's build.gradle, the fml.coreMods.load property is forcibly set. Because this takes place in GradleStartCommon, this has the effect of overwriting any changes made to fml.coreMods.load through the developer's IDE.

Additionally, MinecraftForge/ForgeGradle#504 effectively causes this to apply to all modules in an IDE (e.g. Intellij) project.

The combination of these two issues makes it very difficult to run VanillaFix and any other coremod (e.g. SpongeForge). It would be helpful if VanillaFix didn't forcibly set this system property, allowing the developer to customize it as needed.

[Bug] Fall-damage values wrong? Check videos inside this report.

Hello! I've started noticing that Fall-Damage values are wrong if you compare them to Regular Minecraft (Vanilla). Is this a bug/glitch you guys know about already? If so, sorry if this is a repost.

Check videos below:

This is the test without the Mod VanillaFix: (No damage applied like normal)
https://streamable.com/qgvo2

And this is the test WITH the Mod VanillaFix: (As you can see damage is applied)
https://streamable.com/7do8y

Avaritia items not animating

Many animated items from Avaritia (latest version) aren't animated at all when VanillaFix is installed, items include singularities, neutronium ingots/nuggets, infinite ingots, sword of the cosmos and the endest pearl. (Note that only the non-hardcoded animations seem to be broken by VanillaFix)

Liquids not animating with Optifine, Liquids not animating in tanks

The fire which shows when entities are burning is not animated unless there is a fire block persent nearby.


Many animated items from Avaritia (latest version) aren't animated at all when VanillaFix is installed, items include singularities, neutronium ingots/nuggets, infinite ingots, sword of the cosmos and the endest pearl. (Note that only the non-hardcoded animations seem to be broken by VanillaFix)


Non-flowing liquids aren't animated on the side at all when VanillaFix is installed.

Issue #29 Is still not resolved

The glitch was not fixed, as fall distance still does not reset properly (this is not a problem with snow layers as it still happens on ice/normal blocks):

New video(s):

Modded:
https://www.youtube.com/watch?v=5agBLG7TJu4&feature=youtu.be

Vanilla Environment with the mod isolated on its own:
https://www.youtube.com/watch?v=-6Sla_utRq8&feature=youtu.be

VanillaFix version:
VanillaFix-1.0.5-43.jar

Mod Pack:
Custom Pack

MC Version:
1.12.2

Forge Version:
1.12.2-forge1.12.2-14.23.3.2655

Tested Mod Independently:
Yes

Crash with VanillaFix-1.0.3-30 + OptiFine_1.12.2_HD_U_D2

When loading up the game when forge is constructing mods, past the 2/7 or 3/7 point the game just crashes when both VanillaFix and Optifine are installed together, this crash just makes the game close while it is constructing the mods without leaving a crash log behind. Removing Optifine from the mods list makes the game no longer crash, and if you remove VanillaFix and keep Optifine the game won't crash. So something is going on between the two mods.

The forge version is also:
14.23.3.2655 - 1.12.2

Edit: The new latest version of Optifine also causes this problem - Version OptiFine_1.12.2_HD_U_D3

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.