dimmus / eflete Goto Github PK

When I use the toolbar button to set a white background, the main window background becomes transparent. Should be white.
Seems bug in theme.

Hello dimmus,

Translating software like Eflete is a daunting task...

Crediting Eflete translators’ names would be a nice gesture to show you acknowledge their work and a good incentive to attract more contributors.

When i start editing the frame starts sticked to the upper left corner. When i press any button, it jumps to the center as needed. Worked fine for efl-1.19.

Think of it as another theme migration problem.

Corrupted due to the old edc used.
Watch screenshot

include locale.h in src/bin/common/win32.h (for example)

Hello dimmus,

Out of curiosity (and documentation for translation), I've installed the Tizen Studio Main SDK on my Ubuntu 22.04.2 LTS system.

Just to let you know, building Eflete with the "--enable-tizen" option enabled fails:

"Making all in data
make[2]: Entering directory '/home/batden/Documents/sources/e26/eflete/data'
EDJ eflete.edj
EET color.eet
EDJ ewe.edj
edje_cc: Critical. GROUP ewe/scroller/base/default - state 'clicked:0' does not exist for part 'elm.dragable.vbar'; set in program 'v_mouse_down'
make[2]: *** [Makefile:903: ewe.edj] Error 255
make[2]: Leaving directory '/home/batden/Documents/sources/e26/eflete/data'
make[1]: *** [Makefile:519: all-recursive] Error 1
make[1]: Leaving directory '/home/batden/Documents/sources/e26/eflete'
make: *** [Makefile:430: all] Error 2"

(Latest EFL code from Git)

ewarnings:

• ../src/bin/ui/shortcuts/shortcuts.h:49: warning: "MOD_SHIFT" redefined
  49 | #define MOD_SHIFT (1 << 0)
• ../src/bin/ui/shortcuts/shortcuts.h:51: warning: "MOD_ALT" redefined
  51 | #define MOD_ALT (1 << 2)

see:

https://learn.microsoft.com/en-us/windows/win32/inputdev/wm-hotkey

I think that :

• these macro should be an enum
• they should a prefix, like EFLT or osmething like that

Vincent

When opening eflete like a new project, there's an option to import an edj file, the file can be inserted by typing it but the gui browser/selector doesn't allows to select the .edj files

With make check get segmentation fault on ../config/test-driver:112.

Before that get the compiler note: /usr/local/include/check.h:358:69: note: expected ‘const TTest *’ but argument is of type ‘void (*)(int)’ 358 | CK_DLL_EXP void CK_EXPORT _tcase_add_test(TCase * tc, const TTest * ttest,

Need to investigate this.

Hello dimmus,

Just to let you know, Eflete fails to build on the upcoming Ubuntu mantic.
Everything's okay with the actual Ubuntu LTS though.

Full log here: https://pastebin.ubuntu.com/p/rVW6DfgXZF/

... but i have added it in ewpi

so I think that a check should be added in meson

See preliminary text in wiki.

Eflete has built-in Enventor app integration for manual edc-file editing.
This option needs to be revived.

Not sure, but it might be worth switching to meson build system.
Eflete is not a huge package, so the compilation speed is not extremely critical issue.

Personally, i like good old autotools.

I'm just trying to build and I have this error:

options used:

       -Denable-audio=true \
       -Denable-enventor=true \
       --buildtype=release \

error:

[12/130] /usr/bin/edje_cc -id /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/images -id /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/images/splash -fd /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/../../fonts ../data/themes/default/default.edc data/themes/default/eflete_elm.edj
ninja: build stopped: subcommand failed.
dh_auto_build: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 ninja -j4 -v returned exit code 1

Which I tried manually as:

❯❯❯ /usr/bin/edje_cc -id /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/images -id /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/images/splash -fd /mkdeb/build/amd64/eflete_217842/eflete/data/themes/default/../../fonts ../data/themes/default/default.edc data/themes/default/eflete_elm.edj
ERR<220548>:eet ../src/lib/eet/eet_lib.c:331 eet_flush2() Can't write file 'data/themes/default/eflete_elm.edj'.
## Copy & Paste the below (until EOF) into a terminal, then hit Enter

eina_btlog << EOF
/lib/x86_64-linux-gnu/libeina.so.1 0x7f83828c53ec 0x7f838289a000
/lib/x86_64-linux-gnu/libeina.so.1 0x7f83828c6651 0x7f838289a000
/lib/x86_64-linux-gnu/libeina.so.1 0x7f83828c7c85 0x7f838289a000
/lib/x86_64-linux-gnu/libeet.so.1 0x7f838287683b 0x7f838285c000
/lib/x86_64-linux-gnu/libeet.so.1 0x7f83828776ea 0x7f838285c000
/usr/bin/edje_cc 0x562fce100ca2 0x562fce0e4000
/usr/bin/edje_cc 0x562fce0f55e7 0x562fce0e4000
/lib/x86_64-linux-gnu/libc.so.6 0x7f83820a41ca 0x7f838207d000
/lib/x86_64-linux-gnu/libc.so.6 0x7f83820a4285 0x7f838207d000
/usr/bin/edje_cc 0x562fce0f5fd1 0x562fce0e4000
EOF

[1]    220548 segmentation fault  /usr/bin/edje_cc -id  -id  -fd  ../data/themes/default/default.edc

eina_log shows:

    /lib/x86_64-linux-gnu/libeina.so.1|                   ??/??          :   0 @ _eina_semaphore_free()
    /lib/x86_64-linux-gnu/libeina.so.1|                   ??/??          :   0 @ eina_log_print_cb_stdout()
    /lib/x86_64-linux-gnu/libeina.so.1|                   ??/??          :   0 @ eina_log_print()
    /lib/x86_64-linux-gnu/libeet.so.1 |                   ??/??          :   0 @ eet_data_image_decode_to_surface()
    /lib/x86_64-linux-gnu/libeet.so.1 |                   ??/??          :   0 @ eet_sync()
                 /usr/bin/edje_cc     |                     /            :   0 @ ()
                 /usr/bin/edje_cc     |                     /            :   0 @ ()
    /lib/x86_64-linux-gnu/libc.so.6   | ./csu/../sysdeps/x86/libc-start.c:  74 @ __libc_start_call_main()
    /lib/x86_64-linux-gnu/libc.so.6   |         ./csu/../csu/libc-start.c: 128 @ call_init()
                 /usr/bin/edje_cc     |                     /            :   0 @ ()

Popup content looks collapsed. Button somewhere outside the layout.

Hello Dimmus,

Eflete doesn't build anymore since your recent commits.

batden@galipoli:~/Documents/sources/eflete$ make
make  all-recursive
make[1]: Entering directory '/home/batden/Documents/sources/eflete'
Making all in src
make[2]: Entering directory '/home/batden/Documents/sources/eflete/src'
Making all in lib
make[3]: Entering directory '/home/batden/Documents/sources/eflete/src/lib'
make  all-am
make[4]: Entering directory '/home/batden/Documents/sources/eflete/src/lib'
  CC       ewe_ruler.lo
In file included from ewe_private.h:52,
                 from ewe_ruler.c:9:
/usr/local/include/elementary-1/elm_widget.h:832:10: fatal error: elm_widget_item_eo.h: No such file or directory
  832 | #include "elm_widget_item_eo.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[4]: *** [Makefile:470: ewe_ruler.lo] Error 1
make[4]: Leaving directory '/home/batden/Documents/sources/eflete/src/lib'
make[3]: *** [Makefile:390: all] Error 2
make[3]: Leaving directory '/home/batden/Documents/sources/eflete/src/lib'
make[2]: *** [Makefile:398: all-recursive] Error 1
make[2]: Leaving directory '/home/batden/Documents/sources/eflete/src'
make[1]: *** [Makefile:519: all-recursive] Error 1
make[1]: Leaving directory '/home/batden/Documents/sources/eflete'
make: *** [Makefile:430: all] Error 2

Configure step was OK (plain build, no extra options passed).
EFL are up to date.
Build fails on all my Ubuntu boxes.

Update all EDC files in themes and templates according to the latest changes in EFL.

Tracking issue for:

• https://github.com/dimmus/eflete/security/code-scanning/1

no strndup() on Windows. Use eina_strndup() instead.

This is a minor bug report, something changed since the version 20230318 (commit d557d5e #d557d5e7 ) where some files are installed in a different / strange path, I fixed it manually in my package build but I think should be fixed on upstream, these are the details of my overwritten locations:

/usr/local/share/applications   /usr/share/applications
/usr/local/share/icons          /usr/share/icons
/usr/share/eflete/AUTHORS       /usr/share/doc/eflete/AUTHORS

https://hosted.weblate.org/projects/eflete/eflete/#information
says GPLv3
whereas
https://github.com/dimmus/eflete/blob/master/COPYING
says LGPLv3

Can be changed in
https://hosted.weblate.org/settings/eflete/eflete/
and
https://hosted.weblate.org/settings/eflete/glossary/

This is a major annoying bug for now. 
Freeze the app when it catches the infinite (sometimes semi-infinite :) loop on elm:combobox.
It's happening when you are switching between layouts.

Scenario case: all my builds for packaging are made in a chroot, where they never include the .git directory for performance reasons

In the past, I had this issue too, but I solved it by just using the build option --buildtype=release

Now seems like something in the meson.build file changed that makes this issue happening again

Maybe this is not unique to eflete, I think I have seen this before, so I wonder what would be the best way to deal with this issue, maybe there's a special argument for that?

Basically what I see is that the meson file search for the git command availability, but it doesn't checks if the .git directory is available too (and so then this fails), I think that this verification should be added on the same check

Then in such case, the version should probably get from the Changelog file instead (or some place where the version is set), or just using the one from the meson.build set

Vertical spinner on the top toolbar doesn't work:

1. Buttons do nothing
2. Manual editing (entry) not working.

Horizontal spinner theme damaged. They look collapsed.

Seems have a mess with internal and elementary default theme for spinner.

https://sonarcloud.io/project/overview?id=dimmus_eflete

https://scan.coverity.com/projects/dimmus-eflete/view_defects